Implement Python RMSE Test Module #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP Add session management utils * Create a session at ersilia cli initialization * Remove unused code * start an ersilia session in a dedicated sessions dir that is mapped to the parent process' id which ran the given ersilia command, this will generally be a shell process inside a terminal, but it can also be a process from a bash script * declare session specific defaults * Run all ersilia commands within a single process during standard example run, otherwise ersilia run command does not find a served model bec of running in a different process and therefore in a different session * Move the currently served model's pid to its dedicated session directory * WIP Logging * Redirect tmp logs to model's session logs * catch permission error * Redirect tmp logs to model's session logs * don't use ersilia exception management because we don't exactly want the ersilia process to exit
DhanshreeA
added a commit
that referenced
this pull request
Aug 29, 2024
* Enable Ersilia to serve multiple models simultaneously (#1201) * WIP Add session management utils * Create a session at ersilia cli initialization * Remove unused code * start an ersilia session in a dedicated sessions dir that is mapped to the parent process' id which ran the given ersilia command, this will generally be a shell process inside a terminal, but it can also be a process from a bash script * declare session specific defaults * Run all ersilia commands within a single process during standard example run, otherwise ersilia run command does not find a served model bec of running in a different process and therefore in a different session * Move the currently served model's pid to its dedicated session directory * WIP Logging * Redirect tmp logs to model's session logs * catch permission error * Redirect tmp logs to model's session logs * don't use ersilia exception management because we don't exactly want the ersilia process to exit * copy relevant files * read from 3rd column, logging statements bash output file * run_bash path edit, conda.sh current failed fix * add new size methods, clean directory size method * add additional logging of file types and count * delete dead function * fix run path * uncomment testing * fix bash output file opening (arg1) * change var names for clarity and add debug prints * addtional logging statements + updated read_csv method * fixed updated_read_csv * Delete comments and dead code * clean up read_csv * fix comparison method * add prints * model size calculation update * delete comments, update state variables * add time stamp * add debugging print for thresholds * update threshold debugging statements * implement MRAE + Spearman's * bash output file path log * fix divide by 0 mrae calculation * Update threshold * bash script logging statements * bold message debug * generalize read_csv for different column numbers * uncomment * specify output * include scipy dependecy in pyproject.toml * delete dead function + comment * delete unused var * fairyfloss bckgrnd * clarity code mrae calculation * adjust control flow example method * update metric calculations, delete comments * Update comment wording * remove prints and add log statements * end test command statement * fix log format + delete echo and prints * implement rmse + adjust logging/console messages * Update logging and implement rmse * testing * rebase and comment * remove duplicates and resolve merging * comment * console display --------- Co-authored-by: Dhanshree Arora <DhanshreeA@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
Rebased fork to master branch, implemented RMSE without scikit-learn library. Added console statements to keep track of passed tests.
Changes to be made
N/A
Status
Done
To do
N/A
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
N?A