Implement UncheckedAbruptCompletionMismatch (#160)

Co-authored-by: Jihyeok Park <jihyeok_park@korea.ac.kr>

src/main/scala/esmeta/analyzer/AbsTransfer.scala

@@ -726,7 +726,7 @@ trait AbsTransfer extends Optimized with PruneHelper {
         sem.rpMap += retRp -> (oldRet ⊔ newRet)
         sem.worklist += retRp
 
-  // return if abrupt completion
+  /** return-if-abrupt completion */
   def returnIfAbrupt(
     riaExpr: EReturnIfAbrupt,
     value: AbsValue,

src/main/scala/esmeta/analyzer/AnalysisPoint.scala

@@ -1,6 +1,6 @@
 package esmeta.analyzer
 
-import esmeta.ir.Return
+import esmeta.ir.{Func => _, *}
 import esmeta.cfg.*
 
 /** analysis points */
@@ -39,6 +39,15 @@ case class InternalReturnPoint(
   inline def func = calleeRp.func
 }
 
+/** return-if-abrupt points */
+case class ReturnIfAbruptPoint(
+  cp: ControlPoint,
+  riaExpr: EReturnIfAbrupt,
+) extends AnalysisPoint {
+  inline def view = cp.view
+  inline def func = cp.func
+}
+
 /** control points */
 sealed trait ControlPoint extends AnalysisPoint
 

src/main/scala/esmeta/analyzer/TypeAnalyzer.scala

@@ -4,11 +4,12 @@ import esmeta.{ANALYZE_LOG_DIR, LINE_SEP}
 import esmeta.analyzer.domain.*
 import esmeta.cfg.*
 import esmeta.error.*
-import esmeta.ir.{Return, Func => IRFunc, Name, Param, Local}
+import esmeta.ir.{Func => IRFunc, *}
 import esmeta.ty.*
 import esmeta.ty.util.{Stringifier => TyStringifier}
 import esmeta.util.*
 import esmeta.util.Appender.*
+import esmeta.state.*
 import esmeta.util.BaseUtils.*
 import esmeta.util.SystemUtils.*
 
@@ -61,6 +62,21 @@ class TypeAnalyzer(
   /** abstract transfer function for types */
   trait Transfer extends AbsTransfer {
 
+    /** loading monads */
+    import AbsState.monad.*
+
+    /** return-if-abrupt completion */
+    override def returnIfAbrupt(
+      riaExpr: EReturnIfAbrupt,
+      value: AbsValue,
+      check: Boolean,
+    )(using cp: ControlPoint): Result[AbsValue] = {
+      if (config.uncheckedAbrupt && !check && !value.abruptCompletion.isBottom)
+        val riap = ReturnIfAbruptPoint(cp, riaExpr)
+        addMismatch(UncheckedAbruptCompletionMismatch(riap, value.ty))
+      super.returnIfAbrupt(riaExpr, value, check)
+    }
+
     /** handle calls */
     override def doCall(
       callerNp: NodePoint[Call],
@@ -301,5 +317,6 @@ object TypeAnalyzer {
     arity: Boolean = true,
     paramType: Boolean = true,
     returnType: Boolean = true,
+    uncheckedAbrupt: Boolean = false,
   )
 }

src/main/scala/esmeta/analyzer/TypeMismatch.scala

@@ -29,3 +29,9 @@ case class ArityMismatch(
   cp: CallPoint[Node],
   actual: Int,
 ) extends TypeMismatch(cp)
+
+/** unchecked abrupt completion mismatches */
+case class UncheckedAbruptCompletionMismatch(
+  riap: ReturnIfAbruptPoint,
+  actual: ValueTy,
+) extends TypeMismatch(riap)

src/main/scala/esmeta/analyzer/util/Stringifier.scala

@@ -75,6 +75,10 @@ class Stringifier(
         app >> " when " >> cp
       case InternalReturnPoint(irReturn, calleeRp) =>
         app >> "return statement in " >> calleeRp.func.name >> irReturn
+      case ReturnIfAbruptPoint(riap, riaExpr) =>
+        app >> "returnIfAbrupt"
+        app >> "(" >> (if (riaExpr.check) "?" else "!") >> ") "
+        app >> "in " >> riap.func.name >> riaExpr
 
   // control points
   given cpRule: Rule[ControlPoint] = (app, cp) =>
@@ -131,6 +135,9 @@ class Stringifier(
         app >> "[ArityMismatch] " >> cp
         app :> "- expected: " >> cp.func.arity
         app :> "- actual  : " >> actual
+      case UncheckedAbruptCompletionMismatch(riap, actual) =>
+        app >> "[UncheckedAbruptCompletionMismatch] " >> riap
+        app :> "- actual  : " >> actual
 
   private val addLocRule: Rule[IRElem with LangEdge] = (app, elem) => {
     for {