Add e2e tests to ci #113
Merged
Add e2e tests to ci #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use playwright as an e2e testing tool.
Though I'm a little worried about test flakiness, which I suffered first-hand for months, which also surfaced during testing, as evidenced by this run and this run.
However, with suitable strategies to control flakiness like retry, I think benefit outweight the harm. So I propose integrating e2e as a trial for 2~3 months and test whether it works well. Until the decision to remove e2e tests, I'll maintaini the flaky tests if it arises.