Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More summary improvements. #122

Merged
merged 13 commits into from
Dec 11, 2022
Merged

More summary improvements. #122

merged 13 commits into from
Dec 11, 2022

Conversation

doehyunbaek
Copy link
Collaborator

This PR contains series of commits to improve upon #119.

With additional info about filtered test262 tests provided with changes in #119, this PR puts them inside Summray.scala.

doehyunbaek and others added 7 commits December 6, 2022 06:35
yet --> notsupported

for other elements, e.g. timeout
timeouts -> timeout
timeout --> timeout_count
Previously didn't initialize summary for parseTest. This fixes that.

Also some stylistic changes e.g. snake_case -> camelCase
@doehyunbaek doehyunbaek changed the base branch from main to dev December 9, 2022 06:58
@doehyunbaek
Copy link
Collaborator Author

I think it would be best to squash and rebase for merge. If needed, I wll rebase and tidy up commits.

Copy link
Contributor

@jhnaldo jhnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the suggestions.

src/main/scala/esmeta/test262/Test262.scala Outdated Show resolved Hide resolved
src/main/scala/esmeta/test262/Test262.scala Outdated Show resolved Hide resolved
src/main/scala/esmeta/util/Summary.scala Outdated Show resolved Hide resolved
src/main/scala/esmeta/util/Summary.scala Outdated Show resolved Hide resolved
src/test/scala/esmeta/ESMetaTest.scala Outdated Show resolved Hide resolved
src/test/scala/esmeta/ESMetaTest.scala Outdated Show resolved Hide resolved
src/test/scala/esmeta/ESMetaTest.scala Outdated Show resolved Hide resolved
src/test/scala/esmeta/ESMetaTest.scala Show resolved Hide resolved
src/main/scala/esmeta/util/Summary.scala Outdated Show resolved Hide resolved
@jhnaldo jhnaldo added test Adds tests enhancement Enhance the quality of a feature labels Dec 11, 2022
Copy link
Contributor

@jhnaldo jhnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jhnaldo jhnaldo merged commit 108268a into dev Dec 11, 2022
@jhnaldo jhnaldo deleted the subdivide-notsupported branch December 11, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance the quality of a feature test Adds tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants