Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs in RunJobs #125

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fixed bugs in RunJobs #125

merged 1 commit into from
Dec 12, 2022

Conversation

jhnaldo
Copy link
Contributor

@jhnaldo jhnaldo commented Dec 12, 2022

The expected result of the following result is printing "reachable" and throwing 42:

async function f() {
  await 0;
  print("reachable");
}
f();
throw 42;

However, the current ESMeta only throws 42. It happens because the RunJobs algorithm directly returns the result when the result of a job is an abrupt completion, no matter whether the job queue is empty or not.

This PR fixed this issue, and now ESMeta prints the "reachable" string and throws 42.

@jhnaldo jhnaldo added bug Something isn't working area:lang Related to metalanguage and removed area:lang Related to metalanguage labels Dec 12, 2022
@jhnaldo jhnaldo merged commit 38c4bca into dev Dec 12, 2022
@jhnaldo jhnaldo deleted the fix-run-jobs branch December 12, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant