File-grained NotSupported error #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now parsing logic of metadata of test262 test can also handle features separated just with comma.
They were not supported but included in supported-features.json.
jhnaldo
requested changes
Dec 13, 2022
| @@ -6,4 +6,25 @@ case class NotSupported(reasonPath: NotSupported.ReasonPath) | |||
| object NotSupported: | |||
| type Reason = String | |||
| type ReasonPath = List[Reason] | |||
| def apply(reason: Reason): NotSupported = NotSupported(List(reason)) | |||
| def unapply(ns: NotSupported): Option[ReasonPath] = Some(ns.reasonPath) | |||
There was a problem hiding this comment.
I think it is unnecessary because already NotSupported is defined as a case class.
Suggested change
| def unapply(ns: NotSupported): Option[ReasonPath] = Some(ns.reasonPath) |
There was a problem hiding this comment.
Ah it was left as this because it was once a normal class while refactoring. Thanks for great catch.
Delte unnecessary unapply resolvse this.
jhnaldo
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 1d467c1, error type for not supported cases are subdivided and thrown accordingly.
Additionally, there are some changes to json files used for manual filtering config.
filtered.json-->categorized.jsonyet-categorized.json)supported-features.json\