Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent execution of Test262Test #171

Merged
merged 5 commits into from
Aug 13, 2023
Merged

Concurrent execution of Test262Test #171

merged 5 commits into from
Aug 13, 2023

Conversation

doehyunbaek
Copy link
Collaborator

Support concurrent execution of Test262Test, this is mainly for performance reason.

For the Linux desktop with 12900F, this reduces test time of whole suite from 01:22:22 to 16:41, the benefit may vary between the systems.

Support serial extraction of ecma262 specification. This is mainly to help debugging as debugging concurrent execution of Extractor was a little bit confusing.

@doehyunbaek doehyunbaek requested a review from jhnaldo July 30, 2023 08:38
@doehyunbaek
Copy link
Collaborator Author

I will fix the compl test today.

src/main/scala/esmeta/extractor/Extractor.scala Outdated Show resolved Hide resolved
src/main/scala/esmeta/phase/Test262Test.scala Outdated Show resolved Hide resolved
src/main/scala/esmeta/util/ProgressBar.scala Outdated Show resolved Hide resolved
@doehyunbaek
Copy link
Collaborator Author

I observed the execution of concurrent execution diverging from the serial one. Will open again after I investigate the cause.

@doehyunbaek doehyunbaek marked this pull request as draft August 7, 2023 10:11
@doehyunbaek
Copy link
Collaborator Author

I observed the execution of concurrent execution diverging from the serial one. Will open again after I investigate the cause.

Sorry, there was no discrepancy. There was a change from number of passing tests from this commit to this commit, which made a confusion.

I confirmed the concurrent and serial version outputting the exact same summary

@doehyunbaek doehyunbaek marked this pull request as ready for review August 7, 2023 11:27
Copy link
Contributor

@jhnaldo jhnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly refactored this PR and supported the progress bar with the concurrent Summary. After passing the CI system, I will merge it.

@jhnaldo jhnaldo merged commit a135e04 into dev Aug 13, 2023
6 checks passed
@jhnaldo jhnaldo deleted the dev-parallel-test262 branch August 13, 2023 08:49
@jhnaldo jhnaldo added test Adds tests enhancement Enhance the quality of a feature new feature Implements a new feature labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance the quality of a feature new feature Implements a new feature test Adds tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants