IE8 - Fix #252 'constructor' in Object.defineProperties #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IE8 the 'constructor' property was not being defined by the Object.defineProperties method of the sham because IE8 does not enumerate the constructor property.
|
Thanks! This definitely seems like a strictly better approach regardless. Since this particular sham would only apply in pre-ES5 browsers, testing in IE 8 covers down to IE 6, and I'll manually test this in a few older Chrome/Firefox/Safari/Opera versions before merging. |
ljharb
added a commit
that referenced
this pull request
May 30, 2015
IE8 - Fix #252 'constructor' in Object.defineProperties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #252
In IE8 the 'constructor' property was not being defined by the Object.defineProperties method of the sham because IE8 does not enumerate the constructor property.
I've tested this change manually against IE8 running on Windows XP, but I wasn't able to work out how you do your automated cross browser testing.