[Fix] drop, filter, flatMap, map: rpatch a v8 bug when polyfi…

…lling

See https://issues.chromium.org/issues/336839115

Iterator.prototype.drop/polyfill.js

@@ -3,7 +3,13 @@
 var implementation = require('./implementation');
 
 module.exports = function getPolyfill() {
-	return typeof Iterator === 'function' && typeof Iterator.prototype.drop === 'function'
-		? Iterator.prototype.drop
-		: implementation;
+	if (typeof Iterator === 'function' && typeof Iterator.prototype.drop === 'function') {
+		try {
+			// https://issues.chromium.org/issues/336839115
+			Iterator.prototype.drop.call({ next: null }, 0).next();
+		} catch (e) {
+			return Iterator.prototype.drop;
+		}
+	}
+	return implementation;
 };

Iterator.prototype.filter/polyfill.js

@@ -3,7 +3,13 @@
 var implementation = require('./implementation');
 
 module.exports = function getPolyfill() {
-	return typeof Iterator === 'function' && typeof Iterator.prototype.filter === 'function'
-		? Iterator.prototype.filter
-		: implementation;
+	if (typeof Iterator === 'function' && typeof Iterator.prototype.filter === 'function') {
+		try {
+			// https://issues.chromium.org/issues/336839115
+			Iterator.prototype.filter.call({ next: null }, function () {}).next();
+		} catch (e) {
+			return Iterator.prototype.filter;
+		}
+	}
+	return implementation;
 };

Iterator.prototype.flatMap/polyfill.js

@@ -3,7 +3,13 @@
 var implementation = require('./implementation');
 
 module.exports = function getPolyfill() {
-	return typeof Iterator === 'function' && typeof Iterator.prototype.flatMap === 'function'
-		? Iterator.prototype.flatMap
-		: implementation;
+	if (typeof Iterator === 'function' && typeof Iterator.prototype.flatMap === 'function') {
+		try {
+			// https://issues.chromium.org/issues/336839115
+			Iterator.prototype.flatMap.call({ next: null }, function () {}).next();
+		} catch (e) {
+			return Iterator.prototype.flatMap;
+		}
+	}
+	return implementation;
 };

Iterator.prototype.map/polyfill.js

@@ -3,7 +3,13 @@
 var implementation = require('./implementation');
 
 module.exports = function getPolyfill() {
-	return typeof Iterator === 'function' && typeof Iterator.prototype.map === 'function'
-		? Iterator.prototype.map
-		: implementation;
+	if (typeof Iterator === 'function' && typeof Iterator.prototype.map === 'function') {
+		try {
+			// https://issues.chromium.org/issues/336839115
+			Iterator.prototype.map.call({ next: null }, function () {}).next();
+		} catch (e) {
+			return Iterator.prototype.map;
+		}
+	}
+	return implementation;
 };

README.md

@@ -33,6 +33,11 @@ The main export of the package itself is simply an array of the available direct
  - [`Iterator.prototype.take`](https://tc39.es/proposal-iterator-helpers/#sec-iteratorprototype.take)
  - [`Iterator.prototype.toArray`](https://tc39.es/proposal-iterator-helpers/#sec-iteratorprototype.toarray)
 
+## Environments where this is needed
+
+ - node v22, Chrome >= v122: has a [bug](https://issues.chromium.org/issues/336839115)
+ - node < v22, Chrome < v122, Safari <= v17.1, Firefox <= v125: not implemented
+
 ## Getting started
 
 ```sh

test/Iterator.prototype.every.js

@@ -10,6 +10,7 @@ var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
 var hasPropertyDescriptors = require('has-property-descriptors')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.every');
 var impl = require('../Iterator.prototype.every/implementation');
@@ -30,14 +31,14 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { every(nonIterator); },
+				function () { iterate(every(nonIterator, function () {})); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { every(badNext); },
+				function () { iterate(every(badNext, function () {})); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);

test/Iterator.prototype.filter.js

@@ -10,6 +10,7 @@ var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
 var hasPropertyDescriptors = require('has-property-descriptors')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.filter');
 var impl = require('../Iterator.prototype.filter/implementation');
@@ -30,14 +31,14 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { filter(nonIterator); },
+				function () { iterate(filter(nonIterator, function () {})); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { filter(badNext); },
+				function () { iterate(filter(badNext, function () {})); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);

test/Iterator.prototype.find.js

@@ -9,6 +9,7 @@ var forEach = require('for-each');
 var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.find');
 var impl = require('../Iterator.prototype.find/implementation');
@@ -29,14 +30,14 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { find(nonIterator); },
+				function () { iterate(find(nonIterator, function () {})); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { find(badNext); },
+				function () { iterate(find(badNext, function () {})); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);

test/Iterator.prototype.flatMap.js

@@ -9,6 +9,7 @@ var forEach = require('for-each');
 var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
+var iterate = require('iterate-iterator');
 
 var StringToCodePoints = require('es-abstract/2024/StringToCodePoints');
 
@@ -31,14 +32,14 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { flatMap(nonIterator); },
+				function () { iterate(flatMap(nonIterator, function () {})); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { flatMap(badNext); },
+				function () { iterate(flatMap(badNext, function () {})); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);

test/Iterator.prototype.forEach.js

@@ -9,6 +9,7 @@ var forEachNormal = require('for-each');
 var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.forEach');
 var impl = require('../Iterator.prototype.forEach/implementation');
@@ -29,14 +30,14 @@ module.exports = {
 
 		forEachNormal(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { forEach(nonIterator); },
+				function () { iterate(forEach(nonIterator, function () {})); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { forEach(badNext); },
+				function () { iterate(forEach(badNext, function () {})); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);

test/Iterator.prototype.map.js

@@ -10,6 +10,7 @@ var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
 var generators = require('make-generator-function')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.map');
 var impl = require('../Iterator.prototype.map/implementation');
@@ -30,14 +31,14 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { map(nonIterator); },
+				function () { iterate(map(nonIterator, function () {})); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { map(badNext); },
+				function () { iterate(map(badNext, function () {})); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);

test/Iterator.prototype.reduce.js

@@ -9,6 +9,7 @@ var forEach = require('for-each');
 var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.reduce');
 var impl = require('../Iterator.prototype.reduce/implementation');
@@ -29,14 +30,14 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { reduce(nonIterator); },
+				function () { iterate(reduce(nonIterator, function () {})); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { reduce(badNext); },
+				function () { iterate(reduce(badNext, function () {})); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);

test/Iterator.prototype.some.js

@@ -9,6 +9,7 @@ var forEach = require('for-each');
 var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.some');
 var impl = require('../Iterator.prototype.some/implementation');
@@ -29,14 +30,14 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { some(nonIterator); },
+				function () { iterate(some(nonIterator, function () {})); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { some(badNext); },
+				function () { iterate(some(badNext, function () {})); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);

test/Iterator.prototype.take.js

@@ -9,6 +9,7 @@ var forEach = require('for-each');
 var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.take');
 var impl = require('../Iterator.prototype.take/implementation');
@@ -29,15 +30,15 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { take(nonIterator, 1).next(); },
+				function () { iterate(take(nonIterator, 1)); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			if (nonIterator != null && typeof nonIterator !== 'string') {
 				var badNext = { next: nonIterator };
 				t['throws'](
-					function () { take(badNext, 1).next(); },
+					function () { iterate(take(badNext, 1)); },
 					TypeError,
 					debug(badNext) + ' is not an Object with a callable `next` method'
 				);

test/Iterator.prototype.toArray.js

@@ -9,6 +9,7 @@ var forEach = require('for-each');
 var debug = require('object-inspect');
 var v = require('es-value-fixtures');
 var hasSymbols = require('has-symbols/shams')();
+var iterate = require('iterate-iterator');
 
 var index = require('../Iterator.prototype.toArray');
 var impl = require('../Iterator.prototype.toArray/implementation');
@@ -29,14 +30,14 @@ module.exports = {
 
 		forEach(v.primitives.concat(v.objects), function (nonIterator) {
 			t['throws'](
-				function () { toArray(nonIterator); },
+				function () { iterate(toArray(nonIterator)); },
 				TypeError,
 				debug(nonIterator) + ' is not an Object with a callable `next` method'
 			);
 
 			var badNext = { next: nonIterator };
 			t['throws'](
-				function () { toArray(badNext); },
+				function () { iterate(toArray(badNext)); },
 				TypeError,
 				debug(badNext) + ' is not an Object with a callable `next` method'
 			);