now the cube algorithm counts all the possible combinations between the pairs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioizzo
reviewed
Oct 10, 2023
doc/utilities/cubes.ipynb
Outdated
| @@ -167,7 +168,8 @@ | |||
| " a list containing lists of satelites idx occupying the same cube\n", | |||
| " \"\"\"\n", | |||
| " # init\n", | |||
| " retval = []\n", | |||
| " collision = []\n", | |||
| " combination = []\n", | |||
There was a problem hiding this comment.
I would call this variable pairs.
doc/utilities/cubes.ipynb
Outdated
| @@ -167,7 +168,8 @@ | |||
| " a list containing lists of satelites idx occupying the same cube\n", | |||
| " \"\"\"\n", | |||
| " # init\n", | |||
| " retval = []\n", | |||
| " collision = []\n", | |||
There was a problem hiding this comment.
I would call this variable in_same_cube
|
@bluescarni This is good to go, its a small PR improving on one of the utilities notebooks. Will merge when the CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the list "combination" in the cube algorithm function. In case of >2 particles in the same cube, it computes the combination between all the particles.
At the end I ran another time, and because of the noise, results are different from before.