-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batched mode propagation for satellites with _isimp flag activated #9
Conversation
modified pipeline of _isimp flag
Hi @Rex2000viola , thanks for the PR :) Can you please add tests to make sure that the behavior is as intended. You can add them here: https://github.com/esa/dSGP4/blob/master/tests/test_batched_sgp4.py, by adding for instance: For that you might need a few TLEs that have the |
Hello @Sceki , as requested, I have inserted the test file using 4 TLEs, two with the flag active and two without. Additionally, I have updated the corrected sgp4_batched file. I apologize for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Rex2000viola .. thanks! I have added a couple of minor comments, could you please address them?
In the meanwhile, I will let the workflow run as well and there might be fixes to add if those do not pass
@Rex2000viola I think it's almost ready to merge :) We just miss:
Once these two are pushed I can go ahead and merge |
@Sceki I apologize for the wait. I hope it is okay now. |
@Rex2000viola Looks like it's good to go! Thanks a lot for the contribution, I will merge it! |
I modified the pipeline in order to propagate both satellites with _isimp flag activated and not.