Hide PyTorch trace compilation warnings #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FHof
force-pushed
the
hofmeier/torch_hide_tracer_warnings
branch
from
c45fcc4
to
3b5f6c8
Compare
This was referenced Oct 9, 2023
FHof
force-pushed
the
hofmeier/torch_hide_tracer_warnings
branch
from
3b5f6c8
to
fb32846
Compare
gomezzz
approved these changes
Oct 16, 2023
torchquad/integration/monte_carlo.py
Outdated
Comment on lines
201
to
208
| # The PyTorch trace compilation warnings contain many false | ||
| # positives, so we hide all trace compiler warnings | ||
| def trace_without_warnings(*args, **kwargs): | ||
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings( | ||
| "ignore", category=torch.jit.TracerWarning | ||
| ) | ||
| return torch.jit.trace(*args, **kwargs) |
There was a problem hiding this comment.
I guess you are not making this function a dedicated file in the utils folder to avoid the torch import if possible, right?
There was a problem hiding this comment.
I've moved it to the utils.py file now, which also contains helper functions.
FHof
force-pushed
the
hofmeier/torch_hide_tracer_warnings
branch
from
fb32846
to
f561a61
Compare
I think the function can be moved into the |
The test execution shows warnings about traces being potentially incorrect because the Python3 control flow is not completely recorded. This includes conditions on the shape of the integration domain tensor. Since the only arguments of the compiled integration function are the integrand and integration domain, and the dimensionality of this integration domain is constant, we can ignore the warnings. After this change, the two `get_jit_compiled_integrate` functions hide PyTorch trace compilation warnings with `warnings.filterwarnings`.
FHof
force-pushed
the
hofmeier/torch_hide_tracer_warnings
branch
from
f561a61
to
b088aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test execution shows warnings about traces being potentially incorrect because the Python3 control flow is not completely recorded.
This includes conditions on the shape of the integration domain tensor.
Since the only arguments of the compiled integration function are the integrand and integration domain,
and the dimensionality of this integration domain is constant,
we can ignore the warnings.
After this change, the two
get_jit_compiled_integratefunctions hide PyTorch trace compilation warnings withwarnings.filterwarnings.Alternatively, it is possible to hide the warnings only at the code locations where they appear, but this would significantly increase the code complexity I think, see for example this diff to hide a subset of the warnings.
Resolved Issues
How Has This Been Tested?
Execution of pytest before and after the changes