normal push for ED 5

esbanarango · Aug 1, 2023 · 83f25cc · 83f25cc
1 parent 4d08051
commit 83f25cc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/tests/dummy/app/models/fake-model.ts b/tests/dummy/app/models/fake-model.ts
@@ -48,7 +48,7 @@ class FakeModel extends Model {
   @attr() declare images: any;
   @attr('string') declare condType: string;
 
-  @hasMany('other-model', { async: true, inverse: null }) declare otherFakes: AsyncHasMany<OtherModel>;
+  @hasMany('other-model', { async: true, inverse: 'fakeModel' }) declare otherFakes: AsyncHasMany<OtherModel>;
   @belongsTo('other-model', { async: true, inverse: null }) declare otherFake: AsyncBelongsTo<OtherModel>;
   @belongsTo('async-model', { async: true, inverse: 'fakeModel' }) declare asyncModel: AsyncModel;
 

diff --git a/tests/dummy/app/models/other-model.ts b/tests/dummy/app/models/other-model.ts
@@ -1,11 +1,12 @@
-import Model, { attr } from '@ember-data/model';
-
+import Model, { attr, belongsTo, type AsyncBelongsTo } from '@ember-data/model';
 import { modelValidator, type ValidationsConfig, type ValidatedModel } from 'ember-model-validator';
 
 interface OtherModel extends ValidatedModel, Model {}
 
 @modelValidator
 class OtherModel extends Model {
+  @belongsTo('fake-model', { async: true, inverse: 'otherFakes' }) declare fakeModel: AsyncBelongsTo<OtherModel>;
+
   @attr('string') declare name: string;
 
   validations: ValidationsConfig = {

diff --git a/tests/unit/models/fake-model-test.js b/tests/unit/models/fake-model-test.js
@@ -611,7 +611,11 @@ module('Unit | Model | fake-model', function (hooks) {
 
         let otherFakes = model.get('otherFakes');
         const otherFake = store.createRecord('other-model');
-        otherFakes.pushObject(otherFake);
+        if (otherFakes.push) {
+          otherFakes.push(otherFake);
+        } else {
+          otherFakes.pushObject(otherFake);
+        }
 
         assert.false(model.validate({ only: ['otherFakes'] }));
       });