Add Format validator and prevent 'match is not a function' error.

app/mixins/validator.js

@@ -6,6 +6,7 @@ export default Ember.Mixin.create({
   inclusionMessage: 'is not included in the list',
   numericalityMessage: 'is not a number',
   mailMessage: 'is not a valid email',
+  formatMessage: 'is invalid',
 
 	validationErrors: {},
   isValidNow: true,
@@ -46,9 +47,18 @@ export default Ember.Mixin.create({
     	errors[property].push([this.presenceMessage]);
     }
   },
+  _validateFormat: function(property, validation) {
+    var errors = this.get('validationErrors'),
+        withRegexp = validation.format.with;
+    if (!this.get(property) || String(this.get(property)).match(withRegexp) === null){
+      if (!Ember.isArray(errors[property])) {errors[property] = [];}
+      this.set('isValidNow',false);
+      errors[property].push([this.formatMessage]);
+    }
+  },
   _validateEmail: function(property, validation) {
   	var  errors = this.get('validationErrors');
-    if (!this.get(property) || this.get(property).match(/^([\w-]+(?:\.[\w-]+)*)@((?:[\w-]+\.)*\w[\w-]{0,66})\.([a-z]{2,6}(?:\.[a-z]{2})?)$/i) === null){
+    if (!this.get(property) || String(this.get(property)).match(/^([\w-]+(?:\.[\w-]+)*)@((?:[\w-]+\.)*\w[\w-]{0,66})\.([a-z]{2,6}(?:\.[a-z]{2})?)$/i) === null){
     	if (!Ember.isArray(errors[property])) {errors[property] = [];}
       this.set('isValidNow',false);
     	errors[property].push([this.mailMessage]);

tests/dummy/app/models/fake-model.js

@@ -5,6 +5,7 @@ export default DS.Model.extend(Validator,{
   name: DS.attr('string'),
   email: DS.attr('string'),
 
+  legacyCode: DS.attr('string'),
   lotteryNumber: DS.attr('number'),
 
   otherFakes: DS.hasMany('other-model'),
@@ -18,6 +19,9 @@ export default DS.Model.extend(Validator,{
       presence: true,
       email: true
     },
+    legacyCode:{
+      format: {with: /^[a-zA-Z]+$/}
+    },
     lotteryNumber: {
       numericality: true
     },

tests/unit/mixins/validator-test.js

@@ -36,6 +36,12 @@ describe('ValidatorMixin', function() {
 	      expect(model.get('errors').errorsFor('name').mapBy('message')[0][0]).to.equal(model.presenceMessage);
 		  });
 
+      it('validates the format of the attributes set on `validations.format`', function() {
+        var model = this.subject({legacyCode: 3123123});
+        expect(model.validate()).to.equal(false);
+        expect(model.get('errors').errorsFor('legacyCode').mapBy('message')[0][0]).to.equal(model.formatMessage);
+      });
+
 		  it('validates the email format of the attributes set on `validations.email`', function() {
 	      var model = this.subject({email:'adsfasdf$'});
 	      expect(model.validate()).to.equal(false);
@@ -71,7 +77,7 @@ describe('ValidatorMixin', function() {
 			describe('when data is corrected after validation', function() {
 
 			  it('it clean the erros', function() {
-		      var model = this.subject({email:'adsfasdf$',name:'Jose Rene',lotteryNumber:124});
+		      var model = this.subject({email:'adsfasdf$',name:'Jose Rene',lotteryNumber:124,legacyCode:'abc'});
 		      Ember.run(function() {
 		      	expect(model.validate()).to.equal(false);
 		      	model.set('email','rene@higuita.com');