Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add draft support to mongodb, require pymongo #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cocoon-project
Copy link

a first shot to add mongodb as a backend
needs pymongo ( add to requirements.txt ?)

@escalant3
Copy link
Owner

Hi @cocoon-project,

It looks good!

A couple of things:

  • The if __name__ part could use a clean up. There's a trailing print and some commented out lines that could be removed.
  • Feel free to add pymongo to requirements.txt. It's how the other supported platforms work. It'd be interesting to have optional requirements depending on the system that it's going to be used in the future.
  • You could update the README with some usage examples if you want.

Thanks for your contribution!!

@cocoon-project
Copy link
Author

I work on several other backends , redis , and the native python shelve library
and a way to import dependencies as needed.
i will propose it as soon as tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants