Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @propagate_inbounds to getindex/setindexi! on Vec #102

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add @propagate_inbounds to getindex/setindexi! on Vec #102

merged 1 commit into from
Jan 13, 2023

Conversation

Seelengrab
Copy link
Contributor

This prevented some vectorization, since the boundscheck was not elided, even if inlined. I get a 2x performance boost with this.

@KristofferC
Copy link
Collaborator

Good find.

@KristofferC KristofferC merged commit 705384c into eschnett:master Jan 13, 2023
@Seelengrab Seelengrab deleted the propagate_inbounds branch January 13, 2023 16:09
@Seelengrab Seelengrab mentioned this pull request Jan 13, 2023
Merged
@Seelengrab Seelengrab mentioned this pull request Jan 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Seelengrab @KristofferC