Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird module card gap on firefox #42

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

raar1
Copy link
Collaborator

@raar1 raar1 commented May 17, 2024

Add a fix to make thumbnails align correctly on firefox:

Before:
Screenshot 2024-05-17 at 18-44-37 https __esciencecenter-digital-skills github io

After:
Screenshot 2024-05-17 at 18-43-57 Screenshot

(Checked on Chromium after the fix and now both look the same)

@raar1 raar1 changed the title Fix weird module card firefox Fix weird module card gap on firefox May 17, 2024
@raar1 raar1 requested a review from JaroCamphuijsen May 17, 2024 17:07
Copy link
Collaborator

@JaroCamphuijsen JaroCamphuijsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked this on both Chrome and Firefox and it looks great! feel free to merge, @raar1

@raar1 raar1 merged commit 1c95897 into main May 29, 2024
2 checks passed
@raar1 raar1 deleted the fix_weird_module_card_firefox branch May 29, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants