-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix license #45
Fix license #45
Conversation
@LourensVeen could you have a look at this? |
Ah, I figured there'd be a little viper beneath the grass somewhere... 😃. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just that year needs to be augmented.
README.md
Outdated
# NEBULA | ||
|
||
The NEBULA (Nuxt & eScience Based Universal Learning Application) framework can be used to create an easily maintainable, version-controllable, web-based lesson collection. It is based on [Nuxt.js](https://nuxtjs.org/) and [Vue.js](https://vuejs.org/). | ||
|
||
NEBULA is being created as part of the Netherlands eScience Center Digital Skills programme. | ||
|
||
Copyright 2023 Netherlands eScience Center |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure there's some code from 2024 in there as well, so 2023, 2024
is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do we really have to stack all the years? That will make it a very long statement. Why is the year in there anyway? Doesn't it just apply to anything in the code base and at any time the reader reads it? I often see just one year, and it's sometimes updated to the current year. I've never seen a list of years to which it applies...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, missed this comment.
Yes we do need a year, because copyright expires a certain number of years after the first time the work is published, and so the year of first publication needs to be added so that we know when the work enters the public domain.
If different parts of the work were first published in different years, then you need to list all of them. I guess updating would be correct if you release a new version that completely replaces everything from the previous release, but that's very rare I guess. If something is developed continuously, then you can write 2023-2026 to shorten things a bit.
See also https://www.gnu.org/licenses/gpl-howto.en.html, under "The copyright notice"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but we need both years. Some parts were first published in 2023, and therefore have the copyright year 2023, while others were first published in 2024 and need 2024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurray! Approved by the National Association of Hair Splitters!
Fix #39