Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license #45

Merged
merged 4 commits into from
May 29, 2024
Merged

Fix license #45

merged 4 commits into from
May 29, 2024

Conversation

JaroCamphuijsen
Copy link
Collaborator

Fix #39

  • Fixes the license to use the default github apache2.0 template
  • move copyright info to readme
  • Adds license badge to readme

@JaroCamphuijsen
Copy link
Collaborator Author

@LourensVeen could you have a look at this?

@LourensVeen
Copy link
Collaborator

Ah, I figured there'd be a little viper beneath the grass somewhere... 😃.

Copy link
Collaborator

@LourensVeen LourensVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that year needs to be augmented.

README.md Outdated
# NEBULA

The NEBULA (Nuxt & eScience Based Universal Learning Application) framework can be used to create an easily maintainable, version-controllable, web-based lesson collection. It is based on [Nuxt.js](https://nuxtjs.org/) and [Vue.js](https://vuejs.org/).

NEBULA is being created as part of the Netherlands eScience Center Digital Skills programme.

Copyright 2023 Netherlands eScience Center
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure there's some code from 2024 in there as well, so 2023, 2024 is better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do we really have to stack all the years? That will make it a very long statement. Why is the year in there anyway? Doesn't it just apply to anything in the code base and at any time the reader reads it? I often see just one year, and it's sometimes updated to the current year. I've never seen a list of years to which it applies...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, missed this comment.

Yes we do need a year, because copyright expires a certain number of years after the first time the work is published, and so the year of first publication needs to be added so that we know when the work enters the public domain.

If different parts of the work were first published in different years, then you need to list all of them. I guess updating would be correct if you release a new version that completely replaces everything from the previous release, but that's very rare I guess. If something is developed continuously, then you can write 2023-2026 to shorten things a bit.

See also https://www.gnu.org/licenses/gpl-howto.en.html, under "The copyright notice"

@JaroCamphuijsen JaroCamphuijsen removed the request for review from raar1 May 29, 2024 06:09
Copy link
Collaborator

@LourensVeen LourensVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but we need both years. Some parts were first published in 2023, and therefore have the copyright year 2023, while others were first published in 2024 and need 2024.

Copy link
Collaborator

@LourensVeen LourensVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray! Approved by the National Association of Hair Splitters!

@JaroCamphuijsen JaroCamphuijsen merged commit f5881d1 into main May 29, 2024
2 checks passed
@JaroCamphuijsen JaroCamphuijsen deleted the fix-license branch May 29, 2024 13:09
@JaroCamphuijsen JaroCamphuijsen self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licence not picked up by GitHub
2 participants