Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

feat: add ingressClassName #22

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

lenglet-k
Copy link
Contributor

Kubernetes Ingress need ingressClassName. So we must set this parameter in helm chart.

Copy link
Owner

@eshepelyuk eshepelyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

required items:

  1. values schema + lint test
  2. unit test

@lenglet-k
Copy link
Contributor Author

Hello,

No problem. How you run your test ?

@lenglet-k
Copy link
Contributor Author

lenglet-k commented Nov 24, 2023

Hello,

required items:

1. values schema + lint test

2. unit test

I have do it:

helm lint .
==> Linting .

1 chart(s) linted, 0 chart(s) failed
just test-helm
helm plugin ls | grep unittest || helm plugin install https://github.com/helm-unittest/helm-unittest.git
unittest	0.3.6  	Unit test for helm chart in YAML with ease to keep your chart functional and robust.
helm unittest -f 'test/unit/*.yaml' .

### Chart [ apicurio-registry ] .

 PASS  test deployment-registry.yaml template	test/unit/deployment_registry.yaml
 PASS  test deployment-sync.yaml template	test/unit/deployment_sync.yaml
 PASS  test ingress	test/unit/ingress.yaml
 PASS  test sa	test/unit/sa.yaml

Charts:      1 passed, 1 total
Test Suites: 4 passed, 4 total
Tests:       23 passed, 23 total
Snapshot:    0 passed, 0 total
Time:        46.900894ms

Copy link
Owner

@eshepelyuk eshepelyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz

  1. add lint test case for a new property
  2. rebase and squash a PR into single commit

@lenglet-k
Copy link
Contributor Author

Hello, @eshepelyuk it's done.

@eshepelyuk eshepelyuk merged commit 44023f5 into eshepelyuk:main Nov 24, 2023
@eshepelyuk
Copy link
Owner

Thank you
will be available in
https://github.com/eshepelyuk/apicurio-registry-helm/releases/tag/3.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants