grpc: Wait until all go routines exit in Close() #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not guaranteed that when `transport.Close()` returned, the reader go-routines terminated. All the other channels like, `ctxDone`, `writerDone`, `goAway` are being waited upon for a signal To ensure that `transport.Close()` only return after the reader go-routine terminates: - Wait for the `readerDone` channel to signal the completion This fixes: grpc#2869 RELEASE NOTES: grpc: Wait until reader go routine exits in transport.Close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not guaranteed that when
transport.Close()returned, the reader go-routines terminated. All the other channels like,ctxDone,writerDone,goAwayare being waited upon for a signalWith fix :
Without fix :
cc3be4c17)
To ensure that
transport.Close()only return after the reader go-routine terminates:readerDonechannel to signal the completionThis fixes: grpc#2869
RELEASE NOTES:
grpc: Wait until reader go routine exits in transport.Close()