Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry install failing on github after poetry 1.4.1 release #450

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

dfsp-spirit
Copy link
Collaborator

@dfsp-spirit dfsp-spirit commented Mar 21, 2023

Changes Summary

Test branch to test the CI on github. This branch only contains a minor change to the README and serves to demonstrate that something is wrong with the poetry setup on the GitHub runners.

It also serves to mess around with the GH workflow file to fix the issue, without messing around on dev directly.

This bug could be related to pradyunsg/sphinx-theme-builder/issues/13. See also poetry #7691

UPDATE: I temporarily fixed this by pinning the poetry version to 1.4.0. The bug appeared with the release of poetry 1.4.1 on 2023/03/19. It may be that the real issue is a broken hash (that was not properly validated with poetry 1.4.0, but is now in 1.4.1). So the real culprit may be sphinx-theme-builder (see their issue 39), which introduces the broken hash leading to a _WheelFileValidationError into pydata_sphinx_theme-0.8.1-py3-none-any.whl, which we have as a dependency. See also the issue 1253 of pydata-sphinx-theme.

We will wait for an upstream fix, then remove the poetry version pinning.

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

@dfsp-spirit dfsp-spirit self-assigned this Mar 21, 2023
@dfsp-spirit dfsp-spirit changed the base branch from master to dev March 21, 2023 10:19
@dfsp-spirit dfsp-spirit added Critical Bug A critical error that either complete breaks (parts of) the package or causes erroneous calculation dependencies Pull requests that update a dependency file labels Mar 21, 2023
@dfsp-spirit dfsp-spirit changed the title Test branch off dev Poetry install failing on github Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.40 🎉

Comparison is base (d5ea30c) 68.11% compared to head (f7f18d3) 68.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #450      +/-   ##
==========================================
+ Coverage   68.11%   68.51%   +0.40%     
==========================================
  Files          82       82              
  Lines        9995     9995              
  Branches     2066     2066              
==========================================
+ Hits         6808     6848      +40     
+ Misses       2642     2612      -30     
+ Partials      545      535      -10     

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dfsp-spirit dfsp-spirit marked this pull request as ready for review March 21, 2023 12:20
@dfsp-spirit dfsp-spirit changed the title Poetry install failing on github Poetry install failing on github after poetry 1.4.1 release Mar 21, 2023
@dfsp-spirit
Copy link
Collaborator Author

As discusses, I am merging this now as a temporary fix for our CI.

@dfsp-spirit dfsp-spirit merged commit fbdd28a into dev Mar 21, 2023
@tensionhead tensionhead deleted the test_branch_off_dev branch March 31, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Bug A critical error that either complete breaks (parts of) the package or causes erroneous calculation dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant