REST API: extend the list of my rooms by name and subject #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name => proplists:get_value(roomname, Config), | ||
| subject => proplists:get_value(subject, Config)}; | ||
| _ -> | ||
| [] |
There was a problem hiding this comment.
shouldn't function get_room_details return empty map instead of empty list when the case branch does not return {ok, Config, _} tuple?
There was a problem hiding this comment.
The empty list is correct. Thanks to the lists:flatten which run before encoding, such faulty rooms, if there are, will be filtered out.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds name and subject to the action returning list of room to which user is subscribed.