More parallel tests #1038

michalwski · 2016-10-19T07:16:29Z

Following test SUITE were optimised

mod_ping_SUITE
pubsub_SUITE
login_SUITE
amp_SUITE

gadgetci · 2016-10-19T07:16:34Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 discover_child_nodes_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 738

gadgetci · 2016-10-19T07:16:34Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 retrieve_subscriptions_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 295

gadgetci · 2016-10-19T07:16:35Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 notify_collection_leaf_and_item_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 589

gadgetci · 2016-10-19T07:16:36Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 modify_node_subscriptions_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}, {geralt,1}],


According to Elvis:

Missing space right "," on line 462

gadgetci · 2016-10-19T07:16:37Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 notify_collection_bare_jid_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,2}, {geralt,2}],


According to Elvis:

Missing space right "," on line 616

gadgetci · 2016-10-19T07:16:37Z

test/ejabberd_tests/tests/login_SUITE.erl

    try
-        legacy_auth(NewConfig, legacy_auth_plain),
+        do_legacy_auth(NewSpec, legacy_auth_plain),
        ct:fail("Authenticated but shouldn't")
    catch
        error:{assertion_failed,assert,is_iq_result,_,_,_} ->


According to Elvis:

Missing space right "," on line 476

gadgetci · 2016-10-19T07:16:38Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 notify_collection_bare_jid_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,2}, {geralt,2}],


According to Elvis:

Missing space right "," on line 616

gadgetci · 2016-10-19T07:16:39Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 retrieve_subscriptions_collection_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 692

gadgetci · 2016-10-19T07:16:40Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 retrieve_subscriptions_collection_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 692

gadgetci · 2016-10-19T07:16:40Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 disable_delivery_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 910

gadgetci · 2016-10-19T07:16:41Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 disable_payload_leaf_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 823

gadgetci · 2016-10-19T07:16:42Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 subscribe_unsubscribe_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 190

gadgetci · 2016-10-19T07:16:43Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 disable_notifications_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 327

gadgetci · 2016-10-19T07:16:44Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 disable_notifications_leaf_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 799

gadgetci · 2016-10-19T07:16:44Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 request_all_items_leaf_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 767

gadgetci · 2016-10-19T07:16:45Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 disable_persist_items_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 364

gadgetci · 2016-10-19T07:16:46Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 %%--------------------------------------------------------------------
 %% Tests for unsupported features  - excluded from suite
 %%--------------------------------------------------------------------

 disable_payload_and_persist_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 878

gadgetci · 2016-10-19T07:16:47Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 notify_collection_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 561

gadgetci · 2016-10-19T07:16:47Z

test/ejabberd_tests/tests/login_SUITE.erl

    try
-        legacy_auth(NewConfig, legacy_auth_plain),
+        do_legacy_auth(NewSpec, legacy_auth_plain),
        ct:fail("Authenticated but shouldn't")
    catch
        error:{assertion_failed,assert,is_iq_result,_,_,_} ->


According to Elvis:

Missing space right "," on line 476

gadgetci · 2016-10-19T07:16:48Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 notify_collection_leaf_and_item_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 589

gadgetci · 2016-10-19T07:16:49Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 retrieve_subscriptions_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 295

gadgetci · 2016-10-19T07:16:50Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 disable_payload_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 345

gadgetci · 2016-10-19T07:16:51Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 subscribe_unsubscribe_collection_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 524

gadgetci · 2016-10-19T07:16:51Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 disable_notifications_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 327

gadgetci · 2016-10-19T07:16:52Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 discover_top_level_nodes_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 718

gadgetci · 2016-10-19T07:16:53Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 discover_nodes_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 168

gadgetci · 2016-10-19T07:16:54Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 notify_collection_bare_jid_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,2}, {geralt,2}],


According to Elvis:

Missing space right "," on line 616

gadgetci · 2016-10-19T07:16:54Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 notify_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,2}, {geralt,2}],


According to Elvis:

Missing space right "," on line 228

gadgetci · 2016-10-19T07:16:55Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 notify_collection_and_leaf_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}, {geralt,1}],


According to Elvis:

Missing space right "," on line 644

gadgetci · 2016-10-19T07:16:56Z

test/ejabberd_tests/tests/pubsub_SUITE.erl


 create_delete_collection_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}],


According to Elvis:

Missing space right "," on line 507

gadgetci · 2016-10-19T07:16:57Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 request_all_items_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 253

gadgetci · 2016-10-19T07:16:58Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 purge_all_items_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 271

gadgetci · 2016-10-19T07:16:58Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 retrieve_node_subscriptions_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}, {geralt,1}],


According to Elvis:

Missing space right "," on line 438

gadgetci · 2016-10-19T07:16:59Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 publish_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}],


According to Elvis:

Missing space right "," on line 213

gadgetci · 2016-10-19T07:17:00Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 disable_payload_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 345

gadgetci · 2016-10-19T07:17:01Z

test/ejabberd_tests/tests/pubsub_SUITE.erl

      end).

 send_last_published_item_test(Config) ->
-    escalus:story(
+    escalus:fresh_story(
      Config,
      [{alice,1}, {bob,1}],


According to Elvis:

Missing space right "," on line 414

probably due to refactoring the check if server returns expected nodes was not run

gadgetci reviewed Oct 19, 2016

View reviewed changes

michalwski added 13 commits October 25, 2016 10:02

parallelize mod_ping_SUITE

7e7ccb2

replace macros with functions for pubsbu nodes in pubsub_SUITE

677ac43

replace macros with functions for pubsub leafs in pubsub_SUITE

17eb971

randomize pubsub node and leaf names

b66a22d

use randomized names for second pubsub nodes and leafs

6825ea8

replace ?DOMAIN macro with function reading actaull domain from config

72d78fb

move pubsub modules initialisation to init_per_suite

e0d7a16

fix pubsubs discover nodes check

def9e1d

probably due to refactoring the check if server returns expected nodes was not run

parallelise pubsub_SUITE

9198e1c

use xmpp registration only when needed

c367e2c

parallelise all login groups

ae5c5f2

add missing spaces after , found by Elvis

11079c4

increase wait time between registration

f3f25bb

michalwski force-pushed the more-parallel-tests branch from bfe3759 to f3f25bb Compare October 25, 2016 08:02

michalwski added 2 commits October 25, 2016 11:43

configure s2s connection timeout to 1s for amp_SUITE

d5060f4

make basic group in amp_SUITE parallel

f878497

erszcz merged commit f3b5633 into master Oct 26, 2016

erszcz deleted the more-parallel-tests branch October 26, 2016 08:22

michalwski mentioned this pull request Nov 8, 2016

MongooseIM 2.0.0 #1069

Merged

More parallel tests #1038

More parallel tests #1038

Conversation

michalwski commented Oct 19, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michalwski commented Oct 19, 2016 •

edited

Loading