-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrating from mysql to p1_mysql #1067
Conversation
@@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
-spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elvis:
Missing space right "," on line 721
@@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
-spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
-> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elvis:
Missing space right "," on line 722
@@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
-spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
-> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elvis:
Missing space right "," on line 722
@@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
-spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elvis:
Missing space right "," on line 721
R = mysql_to_odbc(mysql_conn:fetch(State#state.db_ref, Query, | ||
self(), ?QUERY_TIMEOUT)), | ||
R = mysql_to_odbc(p1_mysql_conn:squery(State#state.db_ref, Query, | ||
self(), [{timeout, ?QUERY_TIMEOUT}, {result_type, binary}])), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elvis:
Line 601 is too long: self(), [{timeout, ?QUERY_TIMEOUT}, {result_type, binary}])),.
@@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
-spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
-> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elvis:
Missing space right "," on line 722
@@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
-spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elvis:
Missing space right "," on line 721
@@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
-spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
-> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elvis:
Missing space right "," on line 722
%% ?INFO_MSG("MySQL, Received result~n~p~n", [R]), | ||
R | ||
mysql_to_odbc(p1_mysql_conn:squery(State#state.db_ref, Query, | ||
self(), [{timeout, ?QUERY_TIMEOUT}, {result_type, binary}])), | ||
end, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Compiler:
syntax error before: 'end'
compiler failed with exit status: 1 |
-spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | ||
-> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. | ||
-spec mysql_to_odbc({'data', _} | {'error', _} | {'updated', _}) | ||
-> {'error', _} | {'updated', _} | {'selected', [any()], [tuple()]}. | ||
mysql_to_odbc({updated, MySQLRes}) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Compiler:
Warning: function mysql_to_odbc/1 is unused
3a7a0c5
to
8c2f0c1
Compare
Proposed changes include: