migrating from mysql to p1_mysql #1067
Conversation
| @@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
| -spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
There was a problem hiding this comment.
According to Elvis:
Missing space right "," on line 721
| @@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
| -spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
| -> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. | |||
There was a problem hiding this comment.
According to Elvis:
Missing space right "," on line 722
| @@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
| -spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
| -> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. | |||
There was a problem hiding this comment.
According to Elvis:
Missing space right "," on line 722
| @@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
| -spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
There was a problem hiding this comment.
According to Elvis:
Missing space right "," on line 721
| R = mysql_to_odbc(mysql_conn:fetch(State#state.db_ref, Query, | ||
| self(), ?QUERY_TIMEOUT)), | ||
| R = mysql_to_odbc(p1_mysql_conn:squery(State#state.db_ref, Query, | ||
| self(), [{timeout, ?QUERY_TIMEOUT}, {result_type, binary}])), |
There was a problem hiding this comment.
According to Elvis:
Line 601 is too long: self(), [{timeout, ?QUERY_TIMEOUT}, {result_type, binary}])),.
| @@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
| -spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
| -> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. | |||
There was a problem hiding this comment.
According to Elvis:
Missing space right "," on line 722
| @@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
| -spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
There was a problem hiding this comment.
According to Elvis:
Missing space right "," on line 721
| @@ -721,14 +721,14 @@ mysql_connect(Server, Port, Database, Username, Password) -> | |||
| -spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | |||
| -> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. | |||
There was a problem hiding this comment.
According to Elvis:
Missing space right "," on line 722
| %% ?INFO_MSG("MySQL, Received result~n~p~n", [R]), | ||
| R | ||
| mysql_to_odbc(p1_mysql_conn:squery(State#state.db_ref, Query, | ||
| self(), [{timeout, ?QUERY_TIMEOUT}, {result_type, binary}])), | ||
| end, |
There was a problem hiding this comment.
According to Compiler:
syntax error before: 'end'
|
compiler failed with exit status: 1 |
| -spec mysql_to_odbc({'data',_} | {'error',_} | {'updated',_}) | ||
| -> {'error',_} | {'updated',_} | {'selected',[any()],[tuple()]}. | ||
| -spec mysql_to_odbc({'data', _} | {'error', _} | {'updated', _}) | ||
| -> {'error', _} | {'updated', _} | {'selected', [any()], [tuple()]}. | ||
| mysql_to_odbc({updated, MySQLRes}) -> |
There was a problem hiding this comment.
According to Compiler:
Warning: function mysql_to_odbc/1 is unused
ferigis
force-pushed
the
ferigis.mysql_migration
branch
from
3a7a0c5
to
8c2f0c1
Compare
Proposed changes include: