Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a race condition in rest_client_SUITE #1813

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

arcusfelis
Copy link
Contributor

This PR addresses

====== Suite FAILED: rest_client_SUITE (1 of 30 tests failed)    
                                                                 
                                                                 
                                                                 
====== Test name: add_contact_and_invite                         
====== Reason:    {{badmatch,                                    
                       #{ask => <<"out">>,                       
                         jid => <<"alice12.325484@localhost">>,  
                         subscription => <<"none">>}},           
                   [{rest_client_SUITE,'-add_contact_and_invite/1-fun-0-',2,                                                      
                        [{file,"rest_client_SUITE.erl"},{line,697}]},                                                             
                    {escalus_story,story,4,                      
                        [{file,"src/escalus_story.erl"},{line,72}]},                                                              
                    {rest_client_SUITE,add_contact_and_invite,1, 
                        [{file,"rest_client_SUITE.erl"},{line,643}]},                                                             
                    {test_server,ts_tc,3,                        
                        [{file,"test_server.erl"},{line,1529}]},                                                                  
                    {test_server,run_test_case_eval1,6,
                        [{file,"test_server.erl"},{line,1045}]},
                    {test_server,run_test_case_eval,9,
                        [{file,"test_server.erl"},{line,977}]}]}

Proposed changes include:

  • wait for processing confirmation.

@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #1813 into master will increase coverage by 7.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   67.36%   74.68%   +7.32%     
==========================================
  Files         297      297              
  Lines       27746    27759      +13     
==========================================
+ Hits        18692    20733    +2041     
+ Misses       9054     7026    -2028
Impacted Files Coverage Δ
src/mongoose_fips.erl 41.17% <0%> (-33.83%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 79.57% <0%> (ø) ⬆️
src/mod_pubsub.erl 66.01% <0%> (+0.06%) ⬆️
src/ejabberd_c2s.erl 84.35% <0%> (+0.14%) ⬆️
src/mod_mam.erl 89.43% <0%> (+0.37%) ⬆️
src/p1_fsm_old.erl 37.35% <0%> (+0.37%) ⬆️
src/mod_mam_odbc_arch.erl 89.34% <0%> (+0.4%) ⬆️
src/ejabberd_auth_odbc.erl 50.9% <0%> (+0.9%) ⬆️
src/mod_bosh_socket.erl 81.66% <0%> (+1%) ⬆️
src/mod_muc_light_utils.erl 85.26% <0%> (+1.05%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a41694...388666e. Read the comment docs.

@fenek fenek merged commit a13ee79 into master Apr 18, 2018
@fenek fenek deleted the fix-race-condtion-in-rest-client-suite branch April 18, 2018 12:10
@fenek fenek added this to the 3.0.0 milestone Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants