HTTP auth module #274
Merged
HTTP auth module #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll reopen in a moment to trigger travis build. |
|
travis is using test branch |
|
|
||
| -include("ejabberd.hrl"). | ||
|
|
||
| -define(PREP, begin LUser = jlib:nodeprep(User), LServer = jlib:nameprep(Server) end). |
There was a problem hiding this comment.
This macro is handy, but makes the code unclear (in my opinion). I'd rather use an inline function returning 2 elements tuple.
{LUser, LServer} = prep_user_server(...)
|
Macro removed, it's ready for merge. I will add wiki page once it passes language check. :) |
|
Resolves #211 |
|
Does anyone feel something should be changed/fixed in this extension? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds standard HTTP auth module that can interface directly with external REST API compliant with specifications.