-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C2s testing -- first step #364
Conversation
stream_mgmt_resume_tref, | ||
stream_mgmt_constraint_check_tref | ||
}). | ||
-type aux_key() :: atom(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think putting types in .hrl files is a good idea due to possible name clashes. Namespacing options in Erlang are limited, but let's use them when possible ;)
Your sensible reservation was pre-empted in the commit message:
The types & various other concerns will definitely be separated, but I don't want to fall in the trap of kitchen-sink pull requests. |
Just sayin' :) |
@@ -3100,208 +2973,3 @@ defer_resource_constraint_check(#state{stream_mgmt_constraint_check_tref = undef | |||
State#state{stream_mgmt_constraint_check_tref = TRef}; | |||
defer_resource_constraint_check(State)-> | |||
State. | |||
|
|||
-ifdef(TEST). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to resurrect this tests in next steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly!
This is an initial pull request aimed at easing
ejabberd_c2s
refactoring.Three things have been achieved:
apps/ejabberd2/tests/ejabberd_c2s_SUITE.erl
).c2s
-related defines and record declarations tosrc/ejabberd.hrl
. This is an internal include and still needs work, but it's a first step towards better organization.c2s
dependencies and launch them inejabberd_c2s_SUITE_mocks:[setup/0, teardown/0]