C2s testing -- first step #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| stream_mgmt_resume_tref, | ||
| stream_mgmt_constraint_check_tref | ||
| }). | ||
| -type aux_key() :: atom(). |
There was a problem hiding this comment.
I don't think putting types in .hrl files is a good idea due to possible name clashes. Namespacing options in Erlang are limited, but let's use them when possible ;)
|
Your sensible reservation was pre-empted in the commit message:
The types & various other concerns will definitely be separated, but I don't want to fall in the trap of kitchen-sink pull requests. |
|
Just sayin' :) |
| @@ -3100,208 +2973,3 @@ defer_resource_constraint_check(#state{stream_mgmt_constraint_check_tref = undef | |||
| State#state{stream_mgmt_constraint_check_tref = TRef}; | |||
| defer_resource_constraint_check(State)-> | |||
| State. | |||
|
|
|||
| -ifdef(TEST). | |||
There was a problem hiding this comment.
Remember to resurrect this tests in next steps.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial pull request aimed at easing
ejabberd_c2srefactoring.Three things have been achieved:
apps/ejabberd2/tests/ejabberd_c2s_SUITE.erl).c2s-related defines and record declarations tosrc/ejabberd.hrl. This is an internal include and still needs work, but it's a first step towards better organization.c2sdependencies and launch them inejabberd_c2s_SUITE_mocks:[setup/0, teardown/0]