-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with OTP 18.0 #497
Conversation
Please add Erlang/OTP 18 to travis jobs, if available already. |
travis is using test branch |
@fenek, could you please create a corresponding PR in ejabberd_tests? |
Rebased with master. Travis, be a good boy! |
-spec remove_element(E :: 'error' | tuple(), | ||
Set :: gb_set()) -> gb_set(). | ||
remove_element(E, Set) -> | ||
case ?SETS:is_element(E, Set) of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to check if the element exists? Currently we use gb_sets
here and according to doc - if the element doesn't exist, unchanged set is returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't, that's why I removed these lines. :)
This PR makes MongooseIM compatible with OTP 18.0.