Compatibility with OTP 18.0 #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add Erlang/OTP 18 to travis jobs, if available already. |
|
travis is using test branch |
|
@fenek, could you please create a corresponding PR in ejabberd_tests? |
This was referenced Sep 11, 2015
|
Rebased with master. Travis, be a good boy! |
| -spec remove_element(E :: 'error' | tuple(), | ||
| Set :: gb_set()) -> gb_set(). | ||
| remove_element(E, Set) -> | ||
| case ?SETS:is_element(E, Set) of |
There was a problem hiding this comment.
Why do we need to check if the element exists? Currently we use gb_sets here and according to doc - if the element doesn't exist, unchanged set is returned.
There was a problem hiding this comment.
We don't, that's why I removed these lines. :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes MongooseIM compatible with OTP 18.0.