Refactor inband registration (and cancelation) #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dzol
force-pushed
the
fix-inband-cancelation
branch
3 times, most recently
from
357c96c
to
848cccf
Compare
| #xmlel{name = <<"password">>} | ||
| | QuerySubels]}]} | ||
| %% Clients must register before being able to authenticate. | ||
| process_unauthenticated_iq(Sender, Receiver, #iq{type = set} = Stanza, IPAddr) -> |
There was a problem hiding this comment.
I'd stick to one standard - either use From/To or Sender/Receiver, not both alternately. The same story with IQ/Stanza. For me it was slightly misleading when I was comparing process_unauthenticated_iq to process_iq.
There was a problem hiding this comment.
Okay, changed both: commit 1d811e7.
|
One note from me. Maybe it's good time to move all test related to registration to a separate SUITE? |
|
@michalwski Yeah, sure, I'll make the changes Paweł commented on. Then I'll move them over to their own suite. |
Dzol
force-pushed
the
fix-inband-cancelation
branch
from
2c9b62a
to
3c2df10
Compare
| error_response(IQ, ?ERR_FORBIDDEN) | ||
| end. | ||
|
|
||
| attempt_cancelation(ClientJID, #jid{lserver = ServerDomain}, #iq{id = ID, sub_el = Child} = IQ) -> |
There was a problem hiding this comment.
Oh, sorry, the dictionary adds that US also cancelation :) My mistake.
Dzol
force-pushed
the
fix-inband-cancelation
branch
2 times, most recently
from
6d9df55
to
161d38b
Compare
| process_iq_get(From, To, IQ, IPAddr). | ||
|
|
||
| process_iq(From, To, #iq{type = set} = IQ) -> | ||
| process_iq_set(From, To, IQ, jlib:jid_tolower(From)); |
There was a problem hiding this comment.
Please take a look at jid module and change all the deprecated functions from jlib.
There was a problem hiding this comment.
Commit 2f1765b fixes these.
|
How about |
|
Another test would be for the |
added 21 commits
November 30, 2015 15:33
Move necessary agruments out of the "extras".
That is: `Sender'/`Receiver' ---> `From'/`To', and `Stanza' ---> `IQ'.
Also rename the procedure that helps to switch on the children of the "query" element and use more informative names for the atoms which are returned.
When someone has authenticated, i.e. they are already registered, Mongoose should respond with a `registered' IQ query element.
Matches will succeed when changing password: we were comparing the sender of a stanza to a JID that hadn't been formatted according to XMPP guidelines.
NOTE: This test fails until a fix to Mongoose is made.
Since the password change is an IQ request, even though XEP 0077 does not describe this, we test for an error response.
The procedure in question had an empty string (i.e. "") as a pattern in its head, but it's meant to be a binary (i.e. <<"">>), so add this clause.
The calls made inside `*_per_testcase(null_password, _)' simply shouldn't be necessary to test for an error response when a client tries to register with an null password.
We were matching only on an empty string when we really need to match on an empty binary.
Test for a <resource-constraint/> error-response after making inband registration requests in quick succession NOT just that we receive an error-response. The second paragraph of section 3.1.1 of XEP 0077 may suggest using a <not-acceptable/>, see comment in test for more detail.
Mongoose should restrict the number of registrations, regardles of a client's recent success or failure, within a time period.
This makes it more clear that the timers are prerequisites for both tests.
An "error" stanza will in fact produce a "failed_to_register", not a "bad_response".
This concerns changes to the `{access, register, global}' variable,
used for inband registration.
Dzol
force-pushed
the
fix-inband-cancelation
branch
from
2f1765b
to
e9d5dea
Compare
added 3 commits
December 1, 2015 12:41
Assert timeouts have expired before much of the registration process begins: this'll make sure that registration requests are constrained within a given time period, regardless of a client's recent registration success or failure. It discriminates clients using their IP address.
We use the Erlang binary internally.
Dzol
force-pushed
the
fix-inband-cancelation
branch
from
e9d5dea
to
d754769
Compare
michalwski
added a commit
that referenced
this pull request
Dec 1, 2015
Refactor inband registration (and cancelation)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This began as a task to increase coverage, then became about making Mongoose conform to XEP 0077, but to do this we need to refactor.