Do not create nor update skipped hooks #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalwski
changed the title
| end), | ||
| Reporters = get_reporters_cfg(Port), | ||
| application:set_env(exometer, report, Reporters), | ||
| PortServer = receive |
There was a problem hiding this comment.
I think this receive could be encapsulated inside the carbon_sever module- ex. wait_wait_for_client or sth similar. Btw we can name it carbon_cache_server. Initially, I thought that it might have something to do with carbon copies.
There was a problem hiding this comment.
Good idea. I'll do that.
|
What about testing title's feature - skipped hooks? I see two ways of doing that, either extend carbon_server and make it understand metric reports or use meck to validate if "mongoose_metrics:update/2" has/hasn't been called. |
|
Done. Also I renamed the carbon_server and applied your suggestion. |
michalwski
force-pushed
the
exometer-reporters-stability-improvement
branch
from
86c656b
to
cbe4144
Compare
ppikula
added a commit
that referenced
this pull request
Nov 17, 2015
…ment Do not create nor update skipped hooks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents creating a spiral metric for skipped hook. Such metric is dangerous because it may have lot of (tens of thousands) updates in a minute which can lead to too long message inbox for process holding this metric and can crash
exometer_reporter.Also, this PR adds some tests for metric subscriptions.