[ready to merge] Refactor C2S / SASL / auth interface #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This, as of now, breaks configurations different than PLAIN/internal.
(cherry picked from commit 05c20b1b6929bc7e688f2cef7f2a9a9b90b6ab8f)
(cherry picked from commit 4561804e931cfc0c9b533aeebef92c8c4a757036)
(cherry picked from commit eb7cf11d8565014acd0d550748bdcccceebae8a9)
(cherry picked from commit b301384dd7d9caf0a434a0f2ecbae304844eec3d)
erszcz
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
mongoose_credentialstype,sasl_mechanismsconfig option.A single instance of
mongoose_credentialscorresponds to a single authentication/authorization request. The datatype is instantiated inejabberd_c2swhen the session is initially authenticated. It gathers all information obtained by the chosen SASL mechanism, which is later consumed by the auth backend(s). The auth backends might add more information (like session capabilities, validity period, etc.) when returning the credentials back to C2S - this information can e.g. come from decrypting an authorization token or from an external authorization service. The idea is to have all the bits and pieces of information in one place in order to enable extending the authentication process through hooks (no such hook is introduced in this PR yet).The
sasl_mechanismsoption controls which mechanisms are started on MongooseIM startup as well as their startup order. It's a list ofcyrsasl_*module names.This is not intended for merging yet, as auth backends other than
internalaren't ready. I just want to get feedback from Travis.