-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global metrics only switch #940
Conversation
7e534d1
to
567a88e
Compare
232b9b1
to
66eaa8e
Compare
66eaa8e
to
a3d5b2c
Compare
make_global_groups(Groups) -> | ||
[{make_global_group_name(GN), Opts, Cases} || {GN, Opts, Cases} <- Groups]. | ||
|
||
userspec(User1Count, Config) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should accept the same user specs as escalus:story/3
to make things simpler.
And BTW, why exactly do we need this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of this function is to return escalus:story/3
-compatible userspec, based on presence (or absence) of all_metrics_are_global
flag in test config. When it's present, users from node 2 are used in spec. This makes this choice transparent for actual suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see it now, it's not the easiest thing to follow. From what I understand it assumes that the escalus_users
in Config
contains only correct users. Probably a word of explanation will make things easier for others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Word of explanation like explaining it in a comment to this function, right? No problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what I meant :)
This PR adds
all_metrics_are_global
switch.Proposed changes include:
mongoose_metrics
got some serious refactoring.global
atom) always comes first now.Not all metrics test suites are modified to verify both nodes (with switch enabled and disabled) because they rely on many RPC calls and this mechanism is not ready yet for flexible calls to any node.