fix(prefer-node-protocol): continue on version range check (#206)

eslint-community · Mar 20, 2024 · 14d2ea9 · 14d2ea9
1 parent caab777
commit 14d2ea9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/rules/prefer-node-protocol.js b/lib/rules/prefer-node-protocol.js
@@ -110,7 +110,7 @@ module.exports = {
                 "Program:exit"() {
                     for (const { node, moduleStyle } of targets) {
                         if (!isEnablingThisRule(context, moduleStyle)) {
-                            return
+                            continue
                         }
 
                         if (node.type === "TemplateLiteral") {

diff --git a/tests/lib/rules/prefer-node-protocol.js b/tests/lib/rules/prefer-node-protocol.js
@@ -228,5 +228,17 @@ new RuleTester({
             output: 'const fs = require("node:fs");',
             errors: ["Prefer `node:fs` over `fs`."],
         },
+        {
+            options: [{ version: "12.20.0" }],
+            code: `
+                const fs = require("fs");
+                import buffer from 'buffer'
+            `,
+            output: `
+                const fs = require("fs");
+                import buffer from 'node:buffer'
+            `,
+            errors: ["Prefer `node:buffer` over `buffer`."],
+        },
     ],
 })