Make no-native work with ???

[lparry]

Sorry to be a pain, but I've found that the no-native part of this plugin does not pick up native promises in our project and I'm not 100% why.

At first I thought it might be because we're using the current version of eslint, when I saw this: https://github.com/eslint/eslint/pull/4648/files, but I've run the tests in this plugin against eslint 2 and while a bunch of them fail, the no-native ones pass. We use a huge mess of packages so trying to work out where the bad interaction/transpilation happens is a difficult task.

I've played around with the various lists of references on a scope and found that scope.implicit.left appears to include the native uses of Promise in my project, and in this plugin's tests, so I think we're going to run off this fork for now.

I thought maybe you have a better understanding of eslint internals and might be able to suggest what could cause some references to Promise to not appear in the the .through reference list, or if changing it to .implict.left is a bad idea

[xjamundx]

Thanks for the feedback, I'll take a look tomorrow!
On Thu, May 26, 2016 at 8:27 PM Lucas Parry notifications@github.com
wrote:

Sorry to be a pain, but I've found that the no-native part of this plugin
does not pick up native promises in our project and I'm not 100% why.

At first I thought it might be because we're using the current version of
eslint, when I saw this: https://github.com/eslint/eslint/pull/4648/files,
but I've run the tests in this plugin against eslint 2 and while a bunch of
them fail, the no-native ones pass. We use a huge mess of packages so
trying to work out where the bad interaction/transpilation happens is a
difficult task.

I've played around with the various lists of references on a scope and
found that scope.implicit.left appears to include the native uses of
Promise in my project, and in this plugin's tests, so I think we're going
to run off this fork for now.

I thought maybe you have a better understanding of eslint internals and
might be able to suggest what could cause some references to Promise to
not appear in the the .through reference list, or if changing it to

.implict.left is a bad idea

You can view, comment on, or merge this pull request online at:

#16
Commit Summary

• Make no-native work with eslint 2 too

File Changes

• M rules/no-native.js
  https://github.com/xjamundx/eslint-plugin-promise/pull/16/files#diff-0
  (2)

Patch Links:

• https://github.com/xjamundx/eslint-plugin-promise/pull/16.patch
• https://github.com/xjamundx/eslint-plugin-promise/pull/16.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#16, or mute the
thread
https://github.com/notifications/unsubscribe/AAPBf1Lq3Tz3ta-Cb4ck3rSRlI8Mwkpvks5qFmSlgaJpZM4IoJCP
.

[xjamundx]

Okay looking at this now...

[xjamundx]

I think the problem is if you're in es6 mode, eslint will inject all of the globals into the scope from here:
https://github.com/sindresorhus/globals/blob/master/globals.json#L36

There is an alternative way to do this though without relying on scope.

[xjamundx]

I don't know how scopes work, but this code seems to work!