-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Bump all packages and fix linting #471
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 24 -1
Lines 649 653 +4
Branches 250 246 -4
=========================================
+ Hits 649 653 +4 ☔ View full report in Codecov by Sentry. |
ba2c1f8
to
75e107b
Compare
75e107b
to
4db7f5d
Compare
From now, ESLint 9 is blocked by:
I could ignore those, as they're all dev deps 🤔 |
this is a breaking change. |
The commits here are meant to be rebase merged, but its good that the title is representative of that too 😄 |
what do you think splitting the PR to several smaller ones, for clearer changelogs? |
The only one I would split out would be However if that is the only way to convert the commits to changelog entries, I will split them into 4. |
@scagood : if you want to resolve the conflicts and split out the changes, I'd be happy to do a review. Also, can team members do merges if for another's PR, or is the merging reserved for team leaders? |
Larger Changes
node
less than^18.18.0
(this is inline with eslint package.json:180)eslint
less than^7.0.0
Smaller Changes
eslint-plugin-node
witheslint-plugin-n
npm-run-all
withnpm-run-all2