Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detect-child-process): Empty array case handled #82

Closed

Conversation

MarkKragerup
Copy link
Contributor

No description provided.

@MarkKragerup
Copy link
Contributor Author

@nzakas can you merge this and close #23?

@nzakas
Copy link
Contributor

nzakas commented Mar 28, 2022

I can, but we need to have some tests to validate this fix.

@MarkKragerup MarkKragerup changed the title Empty array case handled. Replaces PR #23 fix(detect-child-process): Empty array case handled. Replaces PR #23 Mar 29, 2022
@MarkKragerup
Copy link
Contributor Author

@nzakas i will add tests to this asap. I see the the PR name failed a check - is it correct now? (i don't think i can trigger a re-run of the checks).

@nzakas nzakas changed the title fix(detect-child-process): Empty array case handled. Replaces PR #23 fix(detect-child-process): Empty array case handled Mar 30, 2022
@nzakas
Copy link
Contributor

nzakas commented Mar 30, 2022

Hmmm, it still seems unhappy. I’ll need to look into why that is. It should update when the PR title is updated.

@MarkKragerup
Copy link
Contributor Author

@nzakas it didn't seem to trigger a re-run on title change, but there was a new merge conflict that i resolved, and that commit triggered the changes. I guess that changing PR name is not actually a commit/push action. Perhaps the action needs more triggers :-) This should be good to merge now, and i can add tests later. Or, we can leave it hanging and add tests before merge.

@nzakas
Copy link
Contributor

nzakas commented Apr 8, 2022

Any pull requests that change rules need to have a test to validate the change before merging.

@nzakas nzakas closed this in 7f97815 Apr 18, 2022
@nzakas
Copy link
Contributor

nzakas commented Apr 18, 2022

Updated myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants