Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-mixed-types] Doesn't catch mixed types in Readonly #500

Closed
RebeccaStevens opened this issue Nov 1, 2022 · 0 comments · Fixed by #480
Closed

[no-mixed-types] Doesn't catch mixed types in Readonly #500

RebeccaStevens opened this issue Nov 1, 2022 · 0 comments · Fixed by #480
Labels
Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.

Comments

@RebeccaStevens
Copy link
Collaborator 

type Foo = Readonly<{
  prop: number;
  method: () => void;
}>
@RebeccaStevens RebeccaStevens added Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. Status: Triage This issue needs to be triaged. labels Nov 1, 2022
@RebeccaStevens RebeccaStevens removed the Status: Triage This issue needs to be triaged. label Jan 26, 2023
RebeccaStevens added a commit that referenced this issue Jan 26, 2023
@RebeccaStevens
fix(no-mixed-types): add support for TypeLiteral inside Readonly<>
266f763 
fix #500
@RebeccaStevens RebeccaStevens mentioned this issue Jan 26, 2023
Merged
github-actions bot pushed a commit that referenced this issue Jan 29, 2023
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
342b86e 
# [5.0.0](v4.4.1...v5.0.0) (2023-01-29)

### Bug Fixes

* drop dependency on tsutils ([7a63d89](7a63d89))
* fix meta data and improve doc generation ([1f50625](1f50625))
* **no-mixed-types:** add support for TypeLiteral inside `Readonly<>` ([1da622d](1da622d)), closes [#500](#500)
* **prefer-immutable-types:** fix `string[]` to `readonly string[]` ([a6a27ff](a6a27ff))
* **prefer-immutable-types:** improve the fixer ([4bba113](4bba113))
* **prefer-tacit:** use suggestions instead of a fixer and improve how that suggestion works ([8473743](8473743))
* **type-declaration-immutability:** don't strip whitespace formatting from node text ([8dcaa4d](8dcaa4d))

### Build System

* bump minimum supported version of node to 16.10 ([23b45d2](23b45d2))
* bump minimum supported version of TypeScript to 4.0.2 ([405102b](405102b))

### Features

* add new strict ruleset and reduce strictness of the recommended ruleset ([26424e0](26424e0))
* **functional-parameters:** add option to ignore lambda function expressions ([044e54b](044e54b))
* **no-classes:** rename rule from `no-class` ([76a8e2d](76a8e2d))
* **no-conditional-statements:** rename rule from `no-conditional-statement` ([82b21fa](82b21fa))
* **no-expression-statements:** rename rule from `no-expression-statement` ([d0f9e98](d0f9e98))
* **no-loop-statements:** rename rule from `no-loop-statement` ([683209d](683209d))
* **no-method-signature:** rename to `prefer-property-signatures` & move it to `stylistic` ruleset ([da2259f](da2259f))
* **no-mixed-types:** rename rule from `no-mixed-type` ([392f9e8](392f9e8))
* **no-this-expression:** remove `no-this-expression` from recommended and lite rulesets ([bbd798b](bbd798b))
* **no-this-expressions:** rename rule from `no-this-expression` ([10c3bb6](10c3bb6))
* **no-throw-statements:** rename rule from `no-throw-statement` ([4be92c8](4be92c8))
* **no-try-statements:** rename rule from `no-try-statement` ([e88828a](e88828a))
* **prefer-immutable-types:** add fixer for class properties ([5e047c2](5e047c2))
* **prefer-immutable-types:** add support for a fixer ([195ee1a](195ee1a))
* **prefer-immutable-types:** create rule ([2552d55](2552d55))
* **prefer-immutable-types:** improve ignore options ([8a35e52](8a35e52))
* **prefer-property-signatures:** rename `ignoreIfReadonly` to `ignoreIfReadonlyWrapped` ([86f354b](86f354b))
* **prefer-readonly-type:** deprecated this rule ([82816a0](82816a0))
* **readonly-type:** create rule ([64af937](64af937))
* remove `@typescript-eslint/prefer-readonly-parameter-types` from `external-recommended` ([72aa204](72aa204))
* rename many of the options ([b47e983](b47e983))
* rename ruleset `no-object-orientation` to `no-other-paradigms` ([7ec10c6](7ec10c6))
* split `external-recommended` rulesets into vanilla and typescript variants ([1e7f77a](1e7f77a))
* **type-declaration-immutability:** add fixer support ([2189397](2189397))
* **type-declaration-immutability:** create rule ([941e774](941e774))
* update ruleset configurations ([c195d8e](c195d8e))

### BREAKING CHANGES

* rename many of the options
* **no-try-statements:** rename rule from `no-try-statement`
* **no-throw-statements:** rename rule from `no-throw-statement`
* **no-this-expressions:** rename rule from `no-this-expression`
* **no-mixed-types:** rename rule from `no-mixed-type`
* **no-loop-statements:** rename rule from `no-loop-statement`
* **no-expression-statements:** rename rule from `no-expression-statement`
* **no-conditional-statements:** rename rule from `no-conditional-statement`
* **no-classes:** rename rule from `no-class`
* **no-this-expression:** remove `no-this-expression` from recommended and lite rulesets
* **prefer-property-signatures:** rename `ignoreIfReadonly` to `ignoreIfReadonlyWrapped` and set it to `false`
by default
* rename ruleset `no-object-orientation` to `no-other-paradigms`
* add new strict ruleset and reduce strictness of the recommended ruleset
* update ruleset configurations
* split `external-recommended` rulesets into vanilla and typescript variants
* remove `@typescript-eslint/prefer-readonly-parameter-types` from `external-recommended`
* **no-method-signature:** rename to `prefer-property-signatures` & move it to `stylistic` ruleset
* bump minimum supported version of TypeScript to 4.0.2
* bump minimum supported version of node to 16.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v5.0.0 eslint-functional/eslint-plugin-functional
1 participant
@RebeccaStevens