Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor generation script improvements #136

Merged
merged 6 commits into from
Oct 4, 2022
Merged

Minor generation script improvements #136

merged 6 commits into from
Oct 4, 2022

Conversation

Shinigami92
Copy link
Collaborator

No description provided.

@Shinigami92 Shinigami92 requested a review from Julien-R44 October 4, 2022 15:25
@Shinigami92 Shinigami92 self-assigned this Oct 4, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review October 4, 2022 15:51
@Julien-R44
Copy link
Collaborator

Looks good to me !
The final polish we needed 😋

I wonder if there is not an eslint rule to add a dot at the end of JSDoc though

Thanks

@Julien-R44 Julien-R44 merged commit 746fcae into main Oct 4, 2022
@Julien-R44 Julien-R44 deleted the minor-script-improvements branch October 4, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julien-R44 Julien-R44 Julien-R44 approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shinigami92 @Julien-R44