Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PredefinedConfig for flat config #146

Merged
merged 2 commits into from
Oct 27, 2022
Merged

feat: add PredefinedConfig for flat config #146

merged 2 commits into from
Oct 27, 2022

Conversation

sxzz
Copy link
Collaborator

@sxzz sxzz commented Oct 25, 2022

No description provided.

@sxzz sxzz requested a review from Shinigami92 as a code owner October 25, 2022 23:05
@Shinigami92 Shinigami92 added the enhancement New feature or request label Oct 26, 2022
Shinigami92
Shinigami92 requested changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide me some link to the docs where explained how to use this

Also not sure if we should combine this with flat config or if it is its own section

Please also add JSDoc to the interfaces / types

@sxzz sxzz requested a review from Shinigami92 October 27, 2022 12:28
Julien-R44
Julien-R44 approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@Julien-R44 Julien-R44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! Thanks

@Shinigami92 Shinigami92 merged commit 00a0647 into eslint-types:main Oct 27, 2022
@sxzz sxzz deleted the feat/flat branch October 27, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julien-R44 Julien-R44 Julien-R44 approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@sxzz sxzz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxzz @Shinigami92 @Julien-R44