Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for vitest #191

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Add support for vitest #191

merged 3 commits into from
Apr 23, 2023

Conversation

azat-io
Copy link
Contributor

@azat-io azat-io commented Apr 22, 2023

@azat-io azat-io requested a review from Shinigami92 as a code owner April 22, 2023 20:18
@Shinigami92 Shinigami92 added the enhancement New feature or request label Apr 22, 2023
@Shinigami92
Copy link
Collaborator

I will merge this tomorrow from my other computer

@Shinigami92
Copy link
Collaborator

Shinigami92 commented Apr 23, 2023 •
edited
Loading

@azat-io on what OS are you running the generate:rules script?
I rerun the script and the diff was very huge 🤔

Oh, also I did some manual steps like adding extends and plugins entries. Just so you know maybe for next time 🙂

@Shinigami92 Shinigami92 changed the title Add Vitest rules Add support for vitest Apr 23, 2023
@Shinigami92 Shinigami92 merged commit 6b485d9 into eslint-types:main Apr 23, 2023
@azat-io
Copy link
Contributor Author

azat-io commented Apr 23, 2023

Lol. I wrote it by hand.
You should add contibuting.md guide. 😄

@azat-io azat-io deleted the feat/vitest branch April 23, 2023 20:26
@sync-by-unito sync-by-unito bot mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92 Shinigami92 is a code owner

Assignees

@azat-io azat-io

@Shinigami92 Shinigami92

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azat-io @Shinigami92