Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Chores to bring in line with other eslint projects #7

Closed
13 tasks done
corbinu opened this issue Jan 15, 2017 · 13 comments
Closed
13 tasks done

Chores to bring in line with other eslint projects #7

corbinu opened this issue Jan 15, 2017 · 13 comments
Labels

Comments

@corbinu
Copy link
Contributor

corbinu commented Jan 15, 2017

I just wanted to create a list of chores that need to be done here please make suggestions @JamesHenry @nzakas

Was wondering what versions of node does eslint officially support? I would like to only downgrade the es6 as much as needed to make it run without Babel.

@nzakas
Copy link
Member

nzakas commented Jan 15, 2017

We support Node 4 and higher. I'd love to get this to a point where it can run natively on Node so we can remove babel, though I'd set that as a longer-term goal.

@corbinu
Copy link
Contributor Author

corbinu commented Jan 15, 2017

@nzakas Ok thanks

Also Node 4 or maintenance? (In other words is 5 supported and at what point after 8 drops does 7 support drop?)

@nzakas
Copy link
Member

nzakas commented Jan 15, 2017

Node 4. We haven't made any other decisions regarding Node version support yet.

@soda0289
Copy link
Member

soda0289 commented Feb 7, 2017

I can help convert the gulpfile to Makefile.js and some other tasks.

@corbinu
Copy link
Contributor Author

corbinu commented Feb 9, 2017

@JamesHenry @nzakas
Just wondering if you guys have any other tasks you want done (or any tasks you think we can put off) before we can make a release of this and do a PR to replace escope in eslint. Hoping to get this in before 4.0

Not trying to rush you guys just having a very bad day as a tslint update appears to have broken linting on a bunch of my projects

@ilyavolodin
Copy link
Member

@corbinu You still have a bit of time before we do 4.0 release. We usually cut a separate branch and do Release Candidates for a few weeks before we release new major version.

@corbinu
Copy link
Contributor Author

corbinu commented Feb 9, 2017

@ilyavolodin Ok thanks ... either way if people could let me know if there is anything else they want in or wants to comment that any of these might not be needed for 4.0 please let me know :)

@soda0289
Copy link
Member

soda0289 commented Feb 9, 2017

After creating the Makefile.js I will also spend some time converting the code to pure es5/es6 instead of transcompiled with babel. After this it should be a little easier to complete the rest of the tasks

@corbinu
Copy link
Contributor Author

corbinu commented Feb 10, 2017

@soda0289 I have some time to work this weekend also do you want to toss me an email and we can plan it out.

@soda0289
Copy link
Member

soda0289 commented Feb 10, 2017

@corbinu I will probably start doing some work on the weekend. Haven't had enough time this week.

This is the order I think would work best.
1. Remove gulp as dependency and create Makefile.js. It will have to call babel to compile files and run tests. (Should be quick and easy)
2. Convert existing tests to es5/es6. Node v4 supports most es6 features. All we really need to do is replace imports/exports with require statement.
3. After tests are converted we can remove the third party directory and maybe create a test runner for the tests that will load espree. Update Makefile.js with new test runner.
4. Convert source code to es5/es6. Same idea as with the tests. Should be straight forward. We can divide up this work to save time. Source code should be moved to lib directory to align with other repositories.
5. Remove extra dependencies. Babel, jsdoc, es6-map, es6-weak-map, jshint

6. Add eslint with rules and fix linting errors.

What are your thoughts?

I will send you an email when I know I can make time to work on this. I feel like Saturday will be when I start writing the Makefile but that may change. WIll keep you updated.

@corbinu
Copy link
Contributor Author

corbinu commented Feb 10, 2017

@soda0289
Sounds good I actually already got the conversion to run on node 4 and the babel removal done. #8

Lets sync up Saturday then on what needs to still be done.

@soda0289
Copy link
Member

Nice Work! Should be pretty straight forward now. I will try and get Makefile.js done soon.

@corbinu
Copy link
Contributor Author

corbinu commented Mar 11, 2017

Closing as all chores have been completed @JamesHenry As soon as a version is released on NPM I will open a PR for eslint to make the switch that way we can get the PR added to the 4 milestone

@corbinu corbinu closed this as completed Mar 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants