Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Convert to ES6 that is supported on Node 4, commonjs modules and remove Babel #9

Closed
wants to merge 2 commits into from

Conversation

corbinu
Copy link
Contributor

@corbinu corbinu commented Feb 10, 2017

This removes Babel, converts to commonjs modules and removes other ES6 features not supported on Node 4. I think it was all destructuring.

Updated version of #8 which removes .defaults and rebased on master

@not-an-aardvark
Copy link
Member

I think you might have accidentally gotten rid of some of the previous commits to master on this branch.

@corbinu
Copy link
Contributor Author

corbinu commented Feb 10, 2017

I was trying to remove some master commits that were on my master but not this one. Not what happened with the errors though will fix

@corbinu
Copy link
Contributor Author

corbinu commented Feb 10, 2017

@not-an-aardvark Looks like travis just needed to be updated to match :)

@not-an-aardvark
Copy link
Member

No, I mean that this PR makes a bunch of changes to unrelated files such as README.md, effectively reverting commits like cf38df0.

@soda0289
Copy link
Member

I think you need to rebase off of master.

@not-an-aardvark
Copy link
Member

Is it possible that when you removed the commits that were on your master, you were accidentally comparing to the estools/escope repo instead of eslint/eslint-scope?

@corbinu
Copy link
Contributor Author

corbinu commented Feb 10, 2017

@not-an-aardvark Ahh I know what I did wrong sorry

@corbinu corbinu closed this Feb 10, 2017
@corbinu corbinu deleted the node-4 branch February 10, 2017 05:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants