-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use checksum instead of mtime for caching to enable CI caching #11319
Comments
@aladdin-add it looks like you're saying that the new version of |
|
Thought I'd share my workaround for this, which is a script that sets mtime to the md5 chksum:
|
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
The version of ESLint you are using.
Latest.
The problem you want to solve.
I want to be able to restore an eslint cache file from a cache on CI and speed up my build.
Your take on the correct solution to problem.
By storing the checksum of a file instead of the mtime in the cache file, I can restore the eslint cache file from a cache in CI and use it shave about 30 seconds off my build time in a repo I'm currently working with. My understanding is that mtime is not set to anything meaningful during a git checkout and that the processing effort required to restore mtime to the git modification time would defeat much if not all of the value of a cached eslint cache file. This could be an optional step, where we continue to allow mtime for faster local caching but have an option to store a chksum for use with CI (and let that chksum take precedence over mtime).
Are you willing to submit a pull request to implement this change?
If I have to, I guess. ;)Sure, why not.The text was updated successfully, but these errors were encountered: