Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex code breaks validation #68

Closed
Bartvds opened this issue Jul 17, 2013 · 3 comments · May be fixed by MarcelRaschke/eslint#7, 47-studio-org/eslint#5 or devcode1981/eslint#5
Closed

Complex code breaks validation #68

Bartvds opened this issue Jul 17, 2013 · 3 comments · May be fixed by MarcelRaschke/eslint#7, 47-studio-org/eslint#5 or devcode1981/eslint#5
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly

Comments

@Bartvds
Copy link

Bartvds commented Jul 17, 2013

If you lint this file using the default settings the validation explodes in (mostly) nonsensical errors:

proto.js: line 1, col 0, Warning - Missing semicolon.
proto.js: line 6, col 4, Warning - Found unexpected statement after a false.
proto.js: line 9, col 4, Warning - Found unexpected statement after a false.
proto.js: line 4, col 8, Warning - Found unexpected statement after a false.
proto.js: line 3, col 26, Warning - Octal literals should not be used.
proto.js: line 3, col 41, Warning - Missing semicolon.
proto.js: line 4, col 8, Warning - Missing semicolon.
proto.js: line 6, col 4, Warning - Missing semicolon.
proto.js: line 7, col 8, Warning - Missing semicolon.
proto.js: line 7, col 8, Warning - Unexpected console statement.
proto.js: line 7, col 20, Warning - Octal literals should not be used.
proto.js: line 11, col 0, Warning - Missing semicolon.
proto.js: line 13, col 4, Warning - Unexpected use of ==, use === instead.
proto.js: line 14, col 4, Warning - Missing semicolon.

14 problems

The line 7, col 8 and line 13, col 4 are expected, but the rest is a bit odd.

@Bartvds
Copy link
Author

Bartvds commented Jul 17, 2013

FYI: I just pulled your recent updates and this is now down to 6 problems! :)

proto.js: line 6, col 4, Warning - Found unexpected statement after a false.
proto.js: line 9, col 4, Warning - Found unexpected statement after a false.
proto.js: line 4, col 8, Warning - Found unexpected statement after a false.
proto.js: line 3, col 46, Warning - Octal literals should not be used.
proto.js: line 7, col 8, Warning - Unexpected console statement.
proto.js: line 13, col 4, Warning - Unexpected use of ==, use === instead.

6 problems

@nzakas
Copy link
Member

nzakas commented Jul 18, 2013

Woohoo! That's progress. What version are you using now? (eslint -v)

On Wed, Jul 17, 2013 at 8:45 AM, Bart van der Schoor <
notifications@github.com> wrote:

FYI: I just pulled your recent updates and this is now down to 6 problems!
:)

proto.js: line 6, col 4, Warning - Found unexpected statement after a false.
proto.js: line 9, col 4, Warning - Found unexpected statement after a false.
proto.js: line 4, col 8, Warning - Found unexpected statement after a false.
proto.js: line 3, col 46, Warning - Octal literals should not be used.
proto.js: line 7, col 8, Warning - Unexpected console statement.
proto.js: line 13, col 4, Warning - Unexpected use of ==, use === instead.

6 problems


Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-21122431
.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@Bartvds
Copy link
Author

Bartvds commented Jul 18, 2013

This was on a checkout of my fork that identified eslint -v as v0.0.7-dev (head at 132d366)

Just now I pulled again (head at 6b794ac) and it it is all fixed!

I now only see the expected errors:

proto.js: line 7, col 8, Warning - Unexpected console statement.
proto.js: line 13, col 4, Warning - Unexpected use of ==, use === instead.

2 problems

You guys are fast, closing this then :)

@Bartvds Bartvds closed this as completed Jul 18, 2013
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly
Projects
None yet
2 participants