Fix: no-mixed-operators false positives with ? :
(fixes #14223)
#14226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #14223
Fixes false positives such as:
What changes did you make? (Give an overview)
Removed invalid
isMixedWithConditionalParent()
check.The other check,
isMixedWithParent()
, already covers binary/logical expression nodes in conditional expressions, so!astUtils.isParenthesised(sourceCode, node.test)
condition inisMixedWithConditionalParent()
was redundant for child binary/logical expressions intest
, and wrong for child binary/logical expressions inconsequent
/alternate
.!astUtils.isParenthesised(sourceCode, node)
condition inisMixedWithConditionalParent()
was also wrong. It gets aConditionalExpression
node when its child binary/logical expression node is being checked, so checking parens around theConditionalExpression
in that case doesn't make sense.Is there anything you'd like reviewers to focus on?