Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate multiline-comment-style & line-comment-position #18435

Merged
merged 4 commits into from
May 9, 2024
Merged

feat: deprecate multiline-comment-style & line-comment-position #18435

merged 4 commits into from
May 9, 2024

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented May 9, 2024 •
edited
Loading

fixes #17681

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

no.

@aladdin-add aladdin-add requested a review from a team as a code owner May 9, 2024 02:19
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label May 9, 2024
@github-actions github-actions bot added the rule Relates to ESLint's core rules label May 9, 2024
@netlify Netlify
Copy link

netlify bot commented May 9, 2024 •
edited
Loading

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 65b9c2b
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/663c9c2cffdc920008255277
😎 Deploy Preview https://deploy-preview-18435--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aladdin-add aladdin-add changed the title feat: deprecate multiline-comment-style & line-comment-position feat: deprecate multiline-comment-style & line-comment-position May 9, 2024
@aladdin-add aladdin-add marked this pull request as draft May 9, 2024 02:38
@aladdin-add aladdin-add marked this pull request as ready for review May 9, 2024 03:24
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion blocked This change can't be completed until another issue is resolved labels May 9, 2024
@aladdin-add aladdin-add removed the blocked This change can't be completed until another issue is resolved label May 9, 2024
mdjermanovic
mdjermanovic approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Since this is a feat, it needs another review from a team member before merging.

Tanujkanti4441
Tanujkanti4441 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nzakas nzakas merged commit 05ef92d into eslint:main May 9, 2024
20 checks passed
@aladdin-add aladdin-add deleted the issue17681 branch May 22, 2024 02:34
This was referenced Jun 3, 2024
Closed
Closed
@WontonSam WontonSam mentioned this pull request Jun 8, 2024
Open
@RickV85 RickV85 mentioned this pull request Jun 8, 2024
Open
This was referenced Jun 8, 2024
Open
Open
@saidsef saidsef mentioned this pull request Jun 8, 2024
Closed
@lholmquist lholmquist mentioned this pull request Jun 8, 2024
Closed
@drwho725 drwho725 mentioned this pull request Jun 8, 2024
Merged
This was referenced Sep 3, 2024
Closed
Closed
@zntb zntb mentioned this pull request Sep 6, 2024
Merged
This was referenced Sep 6, 2024
Open
Open
Open
This was referenced Sep 9, 2024
Open
Open
Open
Open
Open
@lholmquist lholmquist mentioned this pull request Sep 14, 2024
Closed
@WontonSam WontonSam mentioned this pull request Sep 14, 2024
Open
This was referenced Sep 15, 2024
Closed
Closed
Closed
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 19, 2024
Closed
@WontonSam WontonSam mentioned this pull request Sep 20, 2024
Open
@ekmixon ekmixon mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu left review comments

@nzakas nzakas nzakas approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@Tanujkanti4441 Tanujkanti4441 Tanujkanti4441 approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Request: Consider also moving slightly-more-than-formatting rules out of core
5 participants
@aladdin-add @nzakas @antfu @mdjermanovic @Tanujkanti4441