Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to configuration file docs before examples #18535

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #18505

What changes did you make? (Give an overview)

Updated "configuration file" text before examples to be a link to https://eslint.org/docs/latest/use/configure/configuration-files#configuration-file.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner June 1, 2024 16:30
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 1, 2024
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 1, 2024
Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit ed4cb3a
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/665b4cab5beec70008924c4d
😎 Deploy Preview https://deploy-preview-18535--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aladdin-add
Copy link
Member

ci failing has been fixed in the main branch, can you please rebase it, thanks!

@mdjermanovic mdjermanovic reopened this Jun 3, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 73408de into main Jun 3, 2024
30 of 32 checks passed
@nzakas nzakas deleted the issue18505 branch June 3, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Docs: CommonJS examples
3 participants