Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add system theme option #18617

Merged
merged 7 commits into from
Jul 24, 2024
Merged

docs: Add system theme option #18617

merged 7 commits into from
Jul 24, 2024

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Added a system theme option and set it as the default selection.

What changes did you make? (Give an overview)

Added a system theme option and set it as the default selection.
Fixes: #18190
image

Is there anything you'd like reviewers to focus on?

Ensure the changes work across all screen sizes, including tablets and mobile devices.

@amareshsm amareshsm requested a review from a team as a code owner June 20, 2024 20:35
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 7e724bb
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6692a2a54f3c6800087c0116
😎 Deploy Preview https://deploy-preview-18617--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@harish-sethuraman
Copy link
Member

harish-sethuraman commented Jun 21, 2024

Screenshot 2024-06-21 at 10 48 00 AM

Can you once check the layout in tablet mode?

@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 22, 2024
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started reviewing functionally, but then discovered what looks like a user-facing bug. I'll hold off on reviewing more functional stuff in case that bug's fixing necessitates some refactors. Thanks for getting started on this! 🌞

docs/src/assets/js/themes.js Show resolved Hide resolved
docs/src/_includes/layouts/base.html Show resolved Hide resolved
docs/src/assets/js/themes.js Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 5, 2024

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Jul 5, 2024
@amareshsm
Copy link
Member Author

I am working on this PR.

@amareshsm amareshsm removed the Stale label Jul 6, 2024
Copy link

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Jul 23, 2024
@JoshuaKGoldberg
Copy link
Contributor

Ah, I missed that it's waiting on my review - reviewing now.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this looks great!

@amareshsm amareshsm removed the Stale label Jul 24, 2024
@harish-sethuraman harish-sethuraman merged commit 282df1a into main Jul 24, 2024
20 checks passed
@harish-sethuraman harish-sethuraman deleted the add-system-theme branch July 24, 2024 05:43
@harish-sethuraman harish-sethuraman restored the add-system-theme branch July 24, 2024 05:43
@harish-sethuraman harish-sethuraman deleted the add-system-theme branch July 24, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Docs: Option to use system preference for light/dark theme
4 participants