Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use messageId in tests #189

Merged
merged 1 commit into from
May 23, 2024
Merged

feat: use messageId in tests #189

merged 1 commit into from
May 23, 2024

Conversation

mdjermanovic
Copy link
Member

Since the lint config (eslint-plugin-eslint-plugin in particular) is set to enforce the use of messageId's in rules, I think it makes more sense for the test example to use messageId instead of message.

nzakas
nzakas approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit c53fbc6 into main May 23, 2024
11 checks passed
@nzakas nzakas deleted the messageid-in-tests branch May 23, 2024 13:50
@github-actions github-actions bot mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
evaluating feature
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdjermanovic @nzakas @bmish