Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Node.js v23 #196

Merged
merged 2 commits into from
Oct 28, 2024
Merged

ci: add Node.js v23 #196

merged 2 commits into from
Oct 28, 2024

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

CI

What changes did you make? (Give an overview)

Add Node.js v23 environment

Related Issues

No

Is there anything you'd like reviewers to focus on?

No

@snitin315
Copy link
Contributor Author

Looking into the failures.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@snitin315
Copy link
Contributor Author

Updated deps to support Node v23

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 3f22761 into main Oct 28, 2024
11 checks passed
@nzakas nzakas deleted the snitin315-patch-1 branch October 28, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants